Skip to content

[browserstack-service] Add more CIs#11488

Merged
erwinheitzman merged 8 commits intowebdriverio:mainfrom
samarsault:main
Oct 28, 2023
Merged

[browserstack-service] Add more CIs#11488
erwinheitzman merged 8 commits intowebdriverio:mainfrom
samarsault:main

Conversation

@samarsault
Copy link
Contributor

@samarsault samarsault commented Oct 20, 2023

Proposed changes

  • Support more CI providers in browserstack-service

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 20, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@samarsault samarsault changed the title browserstack-service: Add more CIs [browserstack-service] Add more CIs Oct 20, 2023
erwinheitzman
erwinheitzman requested changes Oct 20, 2023
View reviewed changes
Copy link
Member

@erwinheitzman erwinheitzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these, could you sign the CLA?

packages/wdio-browserstack-service/src/util.ts
}
}
// Azure CI
if (env.AZURE_HTTP_USER_AGENT && env.TF_BUILD) {
Copy link
Member

@erwinheitzman erwinheitzman Oct 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already defined at line 641

Copy link
Contributor Author

@samarsault samarsault Oct 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one is for Team Foundation, this is for Azure CI. Ref from cypress

Copy link
Member

@erwinheitzman erwinheitzman Oct 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, in that case we will have to add TF_BUILD_BUILDNUMBER or there will by no distinction between the two ;)

Copy link
Contributor Author

@samarsault samarsault Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

Copy link
Contributor Author

@samarsault samarsault Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you trigger the tests once more? I took the latest pull

@christian-bromann
Copy link
Member

christian-bromann commented Oct 20, 2023

It seems like some of the unit tests are failing that are related to this change 🤔

@samarsault
Copy link
Contributor Author

samarsault commented Oct 26, 2023

@christian-bromann Unit tests are fixed

christian-bromann
christian-bromann approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@erwinheitzman good to go?

erwinheitzman
erwinheitzman approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@erwinheitzman erwinheitzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution 👍

@erwinheitzman erwinheitzman merged commit bb59391 into webdriverio:main Oct 28, 2023
@erwinheitzman erwinheitzman added the PR: Polish 💅 PRs that contain improvements on existing features label Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

@erwinheitzman erwinheitzman erwinheitzman approved these changes

Assignees

No one assigned

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samarsault @christian-bromann @erwinheitzman