Skip to content

#11351 Allure step() not working in failures.#11352

Merged
christian-bromann merged 1 commit intomainfrom
fix_allure_step
Oct 4, 2023
Merged

#11351 Allure step() not working in failures.#11352
christian-bromann merged 1 commit intomainfrom
fix_allure_step

Conversation

@BorisOsipov
Copy link
Member

@BorisOsipov BorisOsipov commented Oct 4, 2023

Proposed changes

Fix error propagating.
Fixes #11351

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@BorisOsipov BorisOsipov requested review from a team and removed request for a team October 4, 2023 18:34
@BorisOsipov BorisOsipov added the PR: Bug Fix 🐛 PRs that contain bug fixes label Oct 4, 2023
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. 👍

@christian-bromann christian-bromann merged commit d94dfb0 into main Oct 4, 2023
@christian-bromann christian-bromann deleted the fix_allure_step branch October 4, 2023 20:06
@weronikazoltaniecka
Copy link

Hi, @BorisOsipov

I've just checked the fix with version 8.16.22 and unfortunately it doesn't work in my case.
All custom steps are passed even if test result is failed (expectation failed in one of custom steps).

{
   "uuid":"2dc82131-e29b-4b61-aed5-f6be73881ad6",
   "historyId":"4b3943ebcc6eb8d55440235d30a0c776",
   "status":"failed",
   "statusDetails":{
      "message":"Expected $.length = 4 to equal 3.\nExpected $[0] = 'x' to equal 'y'.\nExpected $[1] = 'a' to equal 'b'.\nExpected $[2] = 'c' to equal 'd'.\nUnexpected $[3] = 'e' in array.      \n      actual expected\n      \n      [ [ 'xy', 'ab', 'cd' ], 'eUnexpected mode' ]\n      ",
      "trace":"    at <Jasmine>\n    at xyz    at processTicksAndRejections (node:internal/process/task_queues:96:5)"
   },
   "stage":"finished",
   "steps":[
      {
         "name":"Login to xyz",
         "start":1696612920075,
         "stop":1696612922694,
         "stage":"finished",
         "status":"passed",
         "statusDetails":{
            
         },
         "attachments":[
            
         ],
         "parameters":[
            
         ],
         "steps":[
            
         ],
         "description":""
      },
      {
         "name":"Open xyz and verify xyz",
         "start":1696612922861,
         "stop":1696612927926,
         "stage":"finished",
         "status":"passed",
         "statusDetails":{
            
         },
         "attachments":[
            
         ],
         "parameters":[
            
         ],
         "steps":[
            
         ],
         "description":""
      }
   ],
   "attachments":[
      {
         "name":"screenshot_2023-10-06T17_22_08_523Z",
         "type":"image/png",
         "source":"1df75bcb-69bc-4d75-9eee-8716b1d05fd7-attachment.png"
      }
   ],
   "parameters":[
      {
         "name":"browser",
         "value":"chrome-117.0.5938.149"
      },
      {
         "name":"Host",
         "value":"http://localhost:8080/"
      },
      {
         "name":"Chromedriver Version:",
         "value":"117.0.5938.92 (67649b10b92bb182fba357831ef7dd6a1baa5648-refs/branch-heads/5938_62@{#14})"
      },
      {
         "name":"Platform:",
         "value":"mac os x"
      }
   ],
   "labels":[
      {
         "name":"language",
         "value":"javascript"
      },
      {
         "name":"framework",
         "value":"wdio"
      },
      {
         "name":"package",
         "value":"xyz"
      },
      {
         "name":"thread",
         "value":"0-0"
      },
      {
         "name":"suite",
         "value":"xyz"
      },
      {
         "name":"feature",
         "value":"xyz"
      }
   ],
   "links":[
      {
         "url":"abc",
         "type":"tms"
      }
   ],
   "start":1696612916706,
   "name":"xyz",
   "stop":1696612928540
}

I've updated all related packages to the newest version.
packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Allure step() not working in failures.

4 participants