Skip to content

Add coerce to framework cli args#11344

Merged
christian-bromann merged 2 commits intowebdriverio:mainfrom
tamil777selvan:yargs_coerce
Oct 3, 2023
Merged

Add coerce to framework cli args#11344
christian-bromann merged 2 commits intowebdriverio:mainfrom
tamil777selvan:yargs_coerce

Conversation

@tamil777selvan
Copy link
Member

Proposed changes

Fixes #11266

When booleans are provided in CLI, they are converted into strings for all framework options. This conversion result in false failures. To address this issue, a "coerce" method has been implemented to convert stringed booleans into actionable booleans.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Oct 3, 2023
@christian-bromann christian-bromann merged commit b859c21 into webdriverio:main Oct 3, 2023
@tamil777selvan tamil777selvan deleted the yargs_coerce branch October 3, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: mochaOpts.bail from CLI will be ignored

2 participants