Skip to content

Adding support for cucumber profiles & update docs#11067

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
tamil777selvan:cucumber_profiles
Sep 1, 2023
Merged

Adding support for cucumber profiles & update docs#11067
christian-bromann merged 1 commit intowebdriverio:mainfrom
tamil777selvan:cucumber_profiles

Conversation

@tamil777selvan
Copy link
Member

Proposed changes

Adding support for cucumber profiles with limited options.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, lgtm 👍

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Sep 1, 2023
@christian-bromann christian-bromann merged commit fd32cd9 into webdriverio:main Sep 1, 2023
@christian-bromann
Copy link
Member

I am looking into the current build issue with have on Windows and will make a minor release once that is fixed. Great contributions, love to see more 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants