Skip to content

fix(@wdio/cucumber-framework): fix Cucumber types#11065

Merged
christian-bromann merged 5 commits intowebdriverio:mainfrom
erwinheitzman:fix-cucumber-types
Aug 31, 2023
Merged

fix(@wdio/cucumber-framework): fix Cucumber types#11065
christian-bromann merged 5 commits intowebdriverio:mainfrom
erwinheitzman:fix-cucumber-types

Conversation

@erwinheitzman
Copy link
Member

@erwinheitzman erwinheitzman commented Aug 31, 2023 •
edited
Loading

Proposed changes

Fixes #10605

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Reviewers: @webdriverio/project-committers

@erwinheitzman erwinheitzman mentioned this pull request Aug 31, 2023
Closed
3 tasks
christian-bromann
christian-bromann approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Aug 31, 2023
@christian-bromann christian-bromann merged commit 2ebaaab into webdriverio:main Aug 31, 2023
@erwinheitzman erwinheitzman deleted the fix-cucumber-types branch August 31, 2023 15:38
@nextlevelbeard nextlevelbeard mentioned this pull request Sep 5, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: @wdio/cucumber-framework 'DataTable' refers to a value, but is being used as a type here. (TS2749)

2 participants

@erwinheitzman @christian-bromann