(@wdio/globals): fix type propagation#11022
Conversation
|
In light of the upcoming correction, it will be necessary to update the library documentation to reflect the refined approach for importing global types. This new method leverages the @wdio/globals package, which interfaces through the /build/index.d.ts file. Furthermore, please direct your attention to the specific section within the package.json file, labeled "exports"
I appreciate your attention to these updates and thank you for your commitment to enhancing the overall quality of the library. |
|
Will test this locally, thanks :) |
|
@shlomo100 I have tested the change locally which seems to work fine, can you share what you meant by your previous message? As I'm not sure what you mean by checking the exports and changing the docs. |
|
@erwinheitzman @christian-bromann "types": [
"@wdio/globals"
]The automatic completion of the browser global values won't function properly. This adjustment is essential for full functionality. Great job on the fix! |
|
Yes but this is a requirement anyway so no further changes are needed :) |
| @@ -1,4 +1,4 @@ | |||
| import '../types.d.ts' | |||
| /// <reference path="../types.d.ts" /> | |||
There was a problem hiding this comment.
@christian-bromann I see that in the end this part did not come up in the patch for the latest version, why? This is what makes patching work and make types work
There was a problem hiding this comment.
This is what makes patching work and make types work
I don't think so. If you create a new WebdriverIO project through npm init wdio . you will see that types are propagated correctly if the setup follows our configuration recommendation. Please provide a reproducible example if you don't get this.
Proposed changes
fixes #11020
Types of changes
Checklist
Further comments
n/a
Reviewers: @webdriverio/project-committers