Skip to content

add:v7 changes based on #10772#10792

Merged
christian-bromann merged 1 commit intowebdriverio:v7from
hammzj:v7-cucumber-line-number-fix
Jul 24, 2023
Merged

add:v7 changes based on #10772#10792
christian-bromann merged 1 commit intowebdriverio:v7from
hammzj:v7-cucumber-line-number-fix

Conversation

@hammzj
Copy link
Contributor

@hammzj hammzj commented Jul 24, 2023

Proposed changes

Fixed v7 branch to address #7735.
Based on #10772, with only the exact necessary changes made.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@hammzj
Copy link
Contributor Author

hammzj commented Jul 24, 2023

Tested against node v18.10.0 and v.16.19.0 and changes worked for both versions.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jul 24, 2023
@christian-bromann christian-bromann merged commit b601726 into webdriverio:v7 Jul 24, 2023
@hammzj hammzj deleted the v7-cucumber-line-number-fix branch August 23, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants