Skip to content

Allow spec files to be passed via --spec without the full path of the file#10239

Closed
andrew-tompkins wants to merge 4 commits intowebdriverio:mainfrom
andrew-tompkins:issue-9495-spec-cli
Closed

Allow spec files to be passed via --spec without the full path of the file#10239
andrew-tompkins wants to merge 4 commits intowebdriverio:mainfrom
andrew-tompkins:issue-9495-spec-cli

Conversation

@andrew-tompkins
Copy link

Proposed changes

These changes should address this issue: #9495

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 21, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: andrew-tompkins (5fa106a)

@andrew-tompkins
Copy link
Author

Looking into the failed tests.

@christian-bromann
Copy link
Member

@andrew-tompkins let me know if I can help in any way.

@andrew-tompkins
Copy link
Author

@christian-bromann Well I'm not sure why the specs are failing. I changed around the initial PR to fix the specs that were failing at that point. But I'm unsure about the latest failures. To make it harder, I'm having issues getting them to run properly on my local env. It's conflicting with other "work" stuff I have on my laptop.

I'm hoping to come back to this in the next couple days to take another look.

@christian-bromann
Copy link
Member

I updated the branch , let's see what the status is. We had a broken build over the last days due to dependency updates which is now fixed.

@patrickschilder
Copy link

Hi, are there any updates on this pull request?
Currently i'm unable to use wildcards to run my spec files, so it would be great if this gets fixed.

@christian-bromann
Copy link
Member

@djpasch the tests still seem to fail , @andrew-tompkins any updates?

@andrew-tompkins
Copy link
Author

andrew-tompkins commented May 10, 2023

Sorry, I haven't gotten back to this as work has gotten busy lately. Last time I looked though, I wasn't sure what the failing tests were about, and was unable to get them running locally either to try and figure it out.

If I get any spare time, I'll have another look.

@awhisler
Copy link

Any updates on when this will be merged?

@christian-bromann
Copy link
Member

Any updates on when this will be merged?

Did you see @andrew-tompkins comment?

@patrickschilder
Copy link

@christian-bromann as @andrew-tompkins was not able to fix it till now, isn't is possible that you take over this pull request? For me it's the last issue that prevents me from switching to V8

@christian-bromann
Copy link
Member

isn't is possible that you take over this pull request?

I have my own priorities. Would you like to chip in an support?

@bhanuagarwal73
Copy link
Contributor

Eagerly waiting for this

@andrew-tompkins
Copy link
Author

I still have this on my list to come back to but I've been swamped at work lately, and real life is even busier. So not sure when I will get back to this.

If you want to try and have a look at why the specs are failing, that would help a lot.

@christian-bromann christian-bromann force-pushed the main branch 3 times, most recently from de55212 to 5803144 Compare July 20, 2023 16:58
@andrew-tompkins
Copy link
Author

I had a few spare hours, so I came back to look at this. But i'm getting test failures when I run them off the main branch. Are there any known errors in main today?

@christian-bromann
Copy link
Member

@andrew-tompkins awesome, the last commit on main passed. Did you pull everything on the main branch and rebased? This is what I would do:

git checkout main
git pull origin main
git checkout issue-9495-spec-cli
git rebase main

Let me know if this works!

@andrew-tompkins
Copy link
Author

@christian-bromann What I mean was when I run the tests on my local against main, so nothing with my changes, they are failing for me. So I must have something wrong with my setup.

@adrian-cocoara-lgp
Copy link

Hello @christian-bromann and @andrew-tompkins, I know you guys are busy with other stuff, but can we have an ETA for merging this PR? This is the last issue that prevents me to upgrade to v8. Thanks!

@christian-bromann
Copy link
Member

@adrian-cocoara-lgp please get involved help to fix the bug, any help is appreciated.

@christian-bromann
Copy link
Member

resolved by #10921

@andrew-tompkins andrew-tompkins deleted the issue-9495-spec-cli branch November 20, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants