Allow spec files to be passed via --spec without the full path of the file#10239
Allow spec files to be passed via --spec without the full path of the file#10239andrew-tompkins wants to merge 4 commits intowebdriverio:mainfrom
Conversation
|
|
|
Looking into the failed tests. |
|
@andrew-tompkins let me know if I can help in any way. |
|
@christian-bromann Well I'm not sure why the specs are failing. I changed around the initial PR to fix the specs that were failing at that point. But I'm unsure about the latest failures. To make it harder, I'm having issues getting them to run properly on my local env. It's conflicting with other "work" stuff I have on my laptop. I'm hoping to come back to this in the next couple days to take another look. |
|
I updated the branch , let's see what the status is. We had a broken build over the last days due to dependency updates which is now fixed. |
|
Hi, are there any updates on this pull request? |
|
@djpasch the tests still seem to fail , @andrew-tompkins any updates? |
|
Sorry, I haven't gotten back to this as work has gotten busy lately. Last time I looked though, I wasn't sure what the failing tests were about, and was unable to get them running locally either to try and figure it out. If I get any spare time, I'll have another look. |
|
Any updates on when this will be merged? |
Did you see @andrew-tompkins comment? |
|
@christian-bromann as @andrew-tompkins was not able to fix it till now, isn't is possible that you take over this pull request? For me it's the last issue that prevents me from switching to V8 |
I have my own priorities. Would you like to chip in an support? |
|
Eagerly waiting for this |
|
I still have this on my list to come back to but I've been swamped at work lately, and real life is even busier. So not sure when I will get back to this. If you want to try and have a look at why the specs are failing, that would help a lot. |
de55212 to
5803144
Compare
|
I had a few spare hours, so I came back to look at this. But i'm getting test failures when I run them off the |
|
@andrew-tompkins awesome, the last commit on git checkout main
git pull origin main
git checkout issue-9495-spec-cli
git rebase mainLet me know if this works! |
|
@christian-bromann What I mean was when I run the tests on my local against |
|
Hello @christian-bromann and @andrew-tompkins, I know you guys are busy with other stuff, but can we have an ETA for merging this PR? This is the last issue that prevents me to upgrade to v8. Thanks! |
|
@adrian-cocoara-lgp please get involved help to fix the bug, any help is appreciated. |
|
resolved by #10921 |
Proposed changes
These changes should address this issue: #9495
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers