Support for Jasmine sessions for BrowserStack Test Observability (v7)#10173
Support for Jasmine sessions for BrowserStack Test Observability (v7)#10173christian-bromann merged 50 commits intowebdriverio:v7from
Conversation
|
@christian-bromann Please do not review / release this as of now. Will comment once final things are done |
# Conflicts: # packages/wdio-browserstack-service/src/insights-handler.ts # packages/wdio-browserstack-service/src/reporter.ts
| return true | ||
| } | ||
|
|
||
| return false |
There was a problem hiding this comment.
if check regarding framework === 'jasmine' not needed?
There was a problem hiding this comment.
No. For jasmine, we are doing via reporter not through insights_handler. So for jasmine this will not get called.
| retries: { limit: testStats.retries || 0, attempts: testStats.retries || 0 } | ||
| } | ||
|
|
||
| if (eventType == 'TestRunStarted' || eventType == 'TestRunSkipped') { |
There was a problem hiding this comment.
Why is this check specifically for these 2 events?
There was a problem hiding this comment.
We are adding the integrations object here. It is only required for new tests right? That's what we used to do in insight_handler before also.
There was a problem hiding this comment.
Let's add this for TestRunFinished event also in case a user spawns driver inside the test itself in which case currently we would not be sending any integrations data.
| test_run: testData | ||
| } | ||
| if (eventType == 'TestRunSkipped') { | ||
| eventType = 'TestRunFinished' |
There was a problem hiding this comment.
Why are we overriding this?
There was a problem hiding this comment.
Have used TestRunSkipped just to handle some conditions or things to do when tests are skipped. But ultimately, this needs to be send to backend as TestRunFinished. So overriding the TestRunSkippedevent back to TestRunFinished
There was a problem hiding this comment.
This param is being passed from onTestSkip callback of reporter. Would we not miss out on actually skipped tests by doing this? Please confirm this.
There was a problem hiding this comment.
So for those tests also where are called from onTestSkip, we were previously also sending it as a TestRunFinished event right?
There was a problem hiding this comment.
So the test status is being sent as skipped and that reflects on reporting dashboard properly?
There was a problem hiding this comment.
What do we send the event_type for skipped tests in other SDKs?
…o ob_jasmine_fix_build_v7
…rformance_testing # Conflicts: # packages/wdio-browserstack-service/src/insights-handler.ts # packages/wdio-browserstack-service/src/reporter.ts
christian-bromann
left a comment
There was a problem hiding this comment.
Looks good to me, as soon as @amaanbs comments have been addressed and tests are passing we can merge.
# Conflicts: # packages/wdio-browserstack-service/src/insights-handler.ts # packages/wdio-browserstack-service/src/launcher.ts # packages/wdio-browserstack-service/src/reporter.ts # packages/wdio-browserstack-service/src/util.ts
…o ob_jasmine_fix_build_v7
|
Couple of things,
|
|
|
…o ob_jasmine_fix_build_v7
|
Is this ready for merge? |
|
@christian-bromann When can we expect a release on v7 next? |
|
@christian-bromann Can we expect a v7 version release anytime soon? |
|
I haven't been able to look at |
Proposed changes
Related v8 PR: #10013
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers