Skip to content

added observability and session check in browserstack service (v7)#10038

Merged
christian-bromann merged 3 commits intowebdriverio:v7from
sriteja777:v7
Apr 3, 2023
Merged

added observability and session check in browserstack service (v7)#10038
christian-bromann merged 3 commits intowebdriverio:v7from
sriteja777:v7

Conversation

@sriteja777
Copy link
Contributor

@sriteja777 sriteja777 commented Mar 23, 2023

Proposed changes

Previously we assumed that anyone with browserstack service installed wants to run their tests on browserstack only, now we want to allow people run tests locally along with browserstack service for observability. Made necessary changes for that. This PR includes changes for V7.

  • Added test observability user check before setting creds.
  • Added browserstack session check before adding service version

Related V8 PR: #10037

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Mar 26, 2023
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann merged commit 3a8fd60 into webdriverio:v7 Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants