(create-wdio): fix multiple issues, simplify/cleanup code#585
(create-wdio): fix multiple issues, simplify/cleanup code#585erwinheitzman merged 10 commits intowebdriverio:mainfrom
Conversation
|
Thank you for following up on this. |
|
@christian-bromann I resolved all feedback and could remove a bit more code. We do not need to create a package.json anymore as this is done by the |
|
@darkartswizard the issue that it will sometimes use yarn is still an issue that I will tackle separately but any other issues should be resolved with this PR! |
|
I just implemented a new feature where it will use the The logic is now as follows:
I'm very very happy with this progress ^^ |
christian-bromann
left a comment
There was a problem hiding this comment.
Minor comments, but looking good !
|
Thank you for the swift feedback, I think we are good to go 👍 |
christian-bromann
left a comment
There was a problem hiding this comment.
Awesome, let's 🚢 it 👍
I tested fresh installs using two approaches and run with both yarn and npmVideo test of both Findings: 1) New: Regardless if I use I don't see the WebdriverIO version displayed at install anymore. Had to look at the package.json to see 2) When I install with installing in \child2 and \child3 while npm 3) When I installed this way installing in \child2 and \child3
|
|
Hey @darkartswizard thank you for the video (what software did you use? The zooming is great!).
I hope this clears it all up, thanks for the thorough testing! 😁 |
Attempt to fix webdriverio/webdriverio#11581
Changes made:
wdio configcommandwdio configcommand alreadynpm run wdio(where wdio is the binary, not the script) therefore, instead of always using npx, again use the package manager that is used insteadAdditionally there's some new logic: