Skip to content

[context] Replace context object interface description to allow any type as a context#36

Merged
justinfagnani merged 2 commits intomainfrom
context-object
Feb 3, 2023
Merged

[context] Replace context object interface description to allow any type as a context#36
justinfagnani merged 2 commits intomainfrom
context-object

Conversation

@justinfagnani
Copy link
Copy Markdown
Member

Fixes #19 and aligns with Lit's implementation.

cc @benjamind @EisenbergEffect

@justinfagnani justinfagnani changed the title Replace context object interface description to allow any type as a context [context] Replace context object interface description to allow any type as a context Feb 2, 2023
@justinfagnani justinfagnani requested a review from sorvell February 2, 2023 17:26
Copy link
Copy Markdown
Collaborator

@Westbrook Westbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@benjamind
Copy link
Copy Markdown
Collaborator

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[context] are context objects needed?

3 participants