Skip to content

Add typescript support to ARnft#158

Closed
kalwalt wants to merge 47 commits intodevfrom
feature-typescript-version01
Closed

Add typescript support to ARnft#158
kalwalt wants to merge 47 commits intodevfrom
feature-typescript-version01

Conversation

@kalwalt
Copy link
Copy Markdown
Member

@kalwalt kalwalt commented Jan 22, 2021

ARnft Typescript refactoring

Trying to add Typescript support to ARnft.
This PR is based on the @eddiecarbin proposed code ARnft-proposal and the insectMobileDemo.
As discussed with @eddiecarbin and @ThorstenBux on github board and slack channel we move the "rendering code" (threejs...) outside of ARnft. The code will restructured according to the TypeScript language.

List of features/tasks to do:

  • porting all the code to Typescript
  • use of rollup.js instead of webpack
  • load of resources with fetch instead of axios
  • WebWorker inside the library importing jsartoolkitNFT as a module (as before)
  • documentation
  • cleaning the code

kalwalt and others added 9 commits December 15, 2020 00:05
Threejs renderer improves from dev branch
Bumps [axios](https://github.com/axios/axios) from 0.21.0 to 0.21.1.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v0.21.1/CHANGELOG.md)
- [Commits](axios/axios@v0.21.0...v0.21.1)

Signed-off-by: dependabot[bot] <support@github.com>
- migrating form webpack to rollup
- added tsconfig
- packages upgrade and dleted not necessary packages
- removed old code
@kalwalt kalwalt added the 🚀 enhancement New feature or request label Jan 22, 2021
@kalwalt kalwalt self-assigned this Jan 22, 2021
@kalwalt
Copy link
Copy Markdown
Member Author

kalwalt commented Feb 9, 2021

@kalwalt kalwalt mentioned this pull request Mar 11, 2021
@kalwalt
Copy link
Copy Markdown
Member Author

kalwalt commented Mar 20, 2021

loading the new npm package for jsartoolkitNFT solved most of the issues!

@kalwalt
Copy link
Copy Markdown
Member Author

kalwalt commented Mar 31, 2021

I think i made some important progresses: i will start to develop the Entity part now.

@kalwalt
Copy link
Copy Markdown
Member Author

kalwalt commented Apr 15, 2021

I dont't know that this code in this PR is the optimal solution. At this point i have an issue with rollup, probably the plugin that load the worker, within it can't import properly ARToolkitNFT, so it fails to build. I wish to solve this but i'm trying also an alternative approach with webpack, but there are other issues with webpack. I don't know why... i hadn't had these kind of issues with JsartoolkitNFT.

@kalwalt
Copy link
Copy Markdown
Member Author

kalwalt commented May 27, 2021

Closing this, i will do less changes and avoid for now Rollup, Maybe that could be done in another step. Follow PR #184.

@kalwalt kalwalt closed this May 27, 2021
@kalwalt kalwalt deleted the feature-typescript-version01 branch October 9, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant