This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Merged
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: e23abe2 | Previous: 1b367e6 | Ratio |
|---|---|---|---|
processingTx |
22092 ops/sec (±6.79%) |
22803 ops/sec (±7.61%) |
1.03 |
processingContractDeploy |
38688 ops/sec (±8.15%) |
39134 ops/sec (±6.74%) |
1.01 |
processingContractMethodSend |
15833 ops/sec (±8.50%) |
15697 ops/sec (±6.86%) |
0.99 |
processingContractMethodCall |
27057 ops/sec (±8.49%) |
28086 ops/sec (±6.28%) |
1.04 |
abiEncode |
43449 ops/sec (±7.48%) |
44672 ops/sec (±6.81%) |
1.03 |
abiDecode |
29859 ops/sec (±8.03%) |
30809 ops/sec (±8.27%) |
1.03 |
sign |
1558 ops/sec (±0.61%) |
1511 ops/sec (±3.64%) |
0.97 |
verify |
361 ops/sec (±2.85%) |
366 ops/sec (±0.54%) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7389 +/- ##
=======================================
Coverage 94.51% 94.51%
=======================================
Files 218 218
Lines 8557 8557
Branches 2363 2363
=======================================
Hits 8088 8088
Misses 469 469
Flags with carried forward coverage won't be shown. Click here to find out more.
|
danforbes
approved these changes
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used https://www.npmjs.com/package/yarn-audit-fix to automatically update dependencies to fix as many vulnerabilities as possible. See the results below:
before:
144 vulnerabilities found - Packages audited: 1644
Severity: 7 Low | 29 Moderate | 108 High
after:
60 vulnerabilities found - Packages audited: 1659
Severity: 6 Low | 5 Moderate | 49 High
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.