This repository was archived by the owner on Mar 5, 2025. It is now read-only.
fix: return type of sendTransaction in docs#7386
Merged
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: ec12fb1 | Previous: 0915cf4 | Ratio |
|---|---|---|---|
processingTx |
22514 ops/sec (±8.34%) |
21158 ops/sec (±9.09%) |
0.94 |
processingContractDeploy |
39234 ops/sec (±7.21%) |
39840 ops/sec (±7.22%) |
1.02 |
processingContractMethodSend |
16236 ops/sec (±6.41%) |
16219 ops/sec (±7.11%) |
1.00 |
processingContractMethodCall |
27733 ops/sec (±6.47%) |
28092 ops/sec (±7.49%) |
1.01 |
abiEncode |
42727 ops/sec (±7.77%) |
42384 ops/sec (±8.97%) |
0.99 |
abiDecode |
28494 ops/sec (±7.82%) |
30530 ops/sec (±6.45%) |
1.07 |
sign |
1559 ops/sec (±1.17%) |
1490 ops/sec (±3.70%) |
0.96 |
verify |
360 ops/sec (±3.00%) |
364 ops/sec (±0.63%) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7386 +/- ##
=======================================
Coverage 94.51% 94.51%
=======================================
Files 218 218
Lines 8557 8557
Branches 2363 2363
=======================================
Hits 8088 8088
Misses 469 469
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix return type of sendTransaction in docs. I did pretty much exactly the same as here #7245
Fixes #7185
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.