fix: correctly close ws connection in web3-eth-contract integration tests by krzysu · Pull Request #7338 · web3/web3.js

krzysu · 2024-10-17T10:19:34Z

Description

Correctly close ws connection in web3-eth-contract integration tests

Fixes #7231

Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist:

github-actions · 2024-10-17T10:21:42Z

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
10	649.88 kB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
web3.min.js	630.33 kB	0%
../lib/commonjs/index.d.ts	8.72 kB	0%
../lib/commonjs/accounts.d.ts	3.93 kB	0%
../lib/commonjs/types.d.ts	2.67 kB	0%
../lib/commonjs/web3.d.ts	1.38 kB	0%
../lib/commonjs/web3_eip6963.d.ts	1.28 kB	0%
../lib/commonjs/abi.d.ts	1.06 kB	0%
../lib/commonjs/eth.exports.d.ts	280 B	0%
../lib/commonjs/providers.exports.d.ts	183 B	0%
../lib/commonjs/version.d.ts	60 B	0%

github-actions

Benchmark

Details

Benchmark suite	Current: `d238442`	Previous: `efac906`	Ratio
`processingTx`	`22426` ops/sec (`±8.47%`)	`23741` ops/sec (`±5.98%`)	`1.06`
`processingContractDeploy`	`42533` ops/sec (`±7.07%`)	`39369` ops/sec (`±11.37%`)	`0.93`
`processingContractMethodSend`	`16981` ops/sec (`±7.27%`)	`17405` ops/sec (`±6.68%`)	`1.02`
`processingContractMethodCall`	`28505` ops/sec (`±7.48%`)	`28770` ops/sec (`±6.60%`)	`1.01`
`abiEncode`	`46333` ops/sec (`±6.92%`)	`44377` ops/sec (`±8.86%`)	`0.96`
`abiDecode`	`31041` ops/sec (`±8.09%`)	`31118` ops/sec (`±7.50%`)	`1.00`
`sign`	`1595` ops/sec (`±0.49%`)	`1604` ops/sec (`±0.56%`)	`1.01`
`verify`	`364` ops/sec (`±2.97%`)	`369` ops/sec (`±2.79%`)	`1.01`

This comment was automatically generated by workflow using github-action-benchmark.

codecov · 2024-10-17T10:25:54Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.51%. Comparing base (07993c2) to head (1450b8b).
Report is 2 commits behind head on 4.x.

Additional details and impacted files

@@           Coverage Diff           @@
##              4.x    #7338   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files         218      218           
  Lines        8557     8557           
  Branches     2363     2363           
=======================================
  Hits         8088     8088           
  Misses        469      469

Flag	Coverage Δ
UnitTests	`94.51% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

…ests

krzysu · 2024-11-06T09:53:30Z

scripts/system_tests_utils.ts

 export const createLocalAccount = async (web3: Web3) => {
 	const account = web3.eth.accounts.create();
-	await refillAccount((await createTempAccount()).address, account.address, '10000000000000000');
+	await refillAccount((await createTempAccount()).address, account.address, '100000000000000000');


increase refill amount as often tests are failing because of not enough funds

krzysu · 2024-11-06T09:54:13Z

scripts/system_tests_utils.ts

 		(web3Context.provider as unknown as Web3BaseProvider).disconnect();

 		await new Promise(resolve => {
-			setTimeout(resolve, 1000);


why to wait for 1s on each closeOpenConnection close?

krzysu · 2024-11-06T09:56:06Z

scripts/geth.sh

 		npx wait-port -t 10000 "$WEB3_SYSTEM_TEST_PORT"
-		echo "docker run -d -p 3333:3333 ethereum/client-go:v1.13.14-amd64 --nodiscover --nousb --ws --ws.addr 0.0.0.0 --ws.port 3333 --http --http.addr 0.0.0.0 --http.port 3334 --allow-insecure-unlock --http.api personal,web3,eth,admin,debug,txpool,net --ws.api personal,web3,eth,admin,debug,miner,txpool,net --dev"
-        docker run -d -p 3333:3333 ethereum/client-go:v1.13.14-amd64 --nodiscover --nousb --ws --ws.addr 0.0.0.0 --ws.port 3333 --http --http.addr 0.0.0.0 --http.port 3333 --allow-insecure-unlock --http.api personal,web3,eth,admin,debug,txpool,net --ws.api personal,web3,eth,admin,debug,miner,txpool,net --dev
+		echo "docker run -d -p 3333:3333 ethereum/client-go:v1.14.10-amd64 --nodiscover --nousb --ws --ws.addr 0.0.0.0 --ws.port 3333 --http --http.addr 0.0.0.0 --http.port 3334 --allow-insecure-unlock --http.api personal,web3,eth,admin,debug,txpool,net --ws.api personal,web3,eth,admin,debug,miner,txpool,net --dev"


upgrade geth to the latest versioned amd64 release I found, shall we just use the latest tag (client-go:latest-amd64)?
more: https://hub.docker.com/r/ethereum/client-go/tags

yes , use latest.

issue created #7379
PR created #7380

krzysu · 2024-11-06T13:11:15Z

With the upgraded version of Geth, some new errors have started to appear. For example, see: this build https://github.com/web3/web3.js/actions/runs/11702836716/job/32591923473
So I had to revert the geth version to the currently used one in the tests.

jdevcs · 2024-11-07T14:33:34Z

scripts/system_tests_utils.ts

 			const url = getSystemTestProviderUrl();
 			const web3 = new Web3(url);
 			web3.registerPlugin(new HardhatPlugin());
+			// eslint-disable-next-line


I'll suggest to specify and disable exact lint error

and for above instances as well

jdevcs · 2024-11-07T14:40:27Z

With the upgraded version of Geth, some new errors have started to appear. For example, see: this build https://github.com/web3/web3.js/actions/runs/11702836716/job/32591923473 So I had to revert the geth version to the currently used one in the tests.

pls see this in detail and open issue in geth,

jdevcs · 2024-11-07T14:40:50Z

PR looks good to me

github-actions bot reviewed Oct 17, 2024

View reviewed changes

github-actions bot deployed to web3-js-docs (Preview) October 17, 2024 10:26 View deployment

github-actions bot deployed to web3-js-docs (Preview) October 18, 2024 15:04 View deployment

github-actions bot deployed to web3-js-docs (Preview) October 21, 2024 08:09 View deployment

krzysu force-pushed the 7231-contract-integration-test branch from fe60f0c to f0c36ff Compare October 21, 2024 08:13

github-actions bot deployed to web3-js-docs (Preview) October 21, 2024 08:21 View deployment

krzysu force-pushed the 7231-contract-integration-test branch from f0c36ff to 7633c3c Compare October 21, 2024 08:31

github-actions bot deployed to web3-js-docs (Preview) October 21, 2024 08:38 View deployment

krzysu force-pushed the 7231-contract-integration-test branch from 7633c3c to e9afeb5 Compare October 21, 2024 08:50

github-actions bot deployed to web3-js-docs (Preview) October 21, 2024 08:57 View deployment

krzysu force-pushed the 7231-contract-integration-test branch from e9afeb5 to f2e11d6 Compare October 21, 2024 09:16

github-actions bot deployed to web3-js-docs (Preview) October 21, 2024 09:24 View deployment

krzysu force-pushed the 7231-contract-integration-test branch from f2e11d6 to 1100490 Compare October 21, 2024 09:28

github-actions bot deployed to web3-js-docs (Preview) October 21, 2024 09:36 View deployment

krzysu force-pushed the 7231-contract-integration-test branch from 1100490 to fa3f764 Compare October 21, 2024 09:43

github-actions bot deployed to web3-js-docs (Preview) October 21, 2024 09:50 View deployment

krzysu force-pushed the 7231-contract-integration-test branch 11 times, most recently from 95f4f29 to 53cb976 Compare October 21, 2024 13:26

github-actions bot deployed to web3-js-docs (Preview) October 21, 2024 13:37 View deployment

krzysu force-pushed the 7231-contract-integration-test branch 8 times, most recently from a2f3782 to 6433db8 Compare November 1, 2024 16:24

Kris Urbas and others added 10 commits November 6, 2024 10:42

fix: correctly close ws connection in web3-eth-contract integration t…

0bd4d22

…ests

remove detectOpenHandles

afe5ed6

searching for open connections

1a01207

cleanup

8e7cc97

rewrite tests using processAsync

6d899a2

figure out what is wrong with signAndSendContractMethod

309edde

debugging http tests

902cbdb

upgrade geth

021f8c6

cleanup

bca80e7

fixing issues with hardhat test

6fdddec

krzysu commented Nov 6, 2024

View reviewed changes

krzysu added 2 commits November 6, 2024 11:43

last failing test

75f9224

last experiment

28790b4

fixing more issues with tests

8396c63

avkos approved these changes Nov 6, 2024

View reviewed changes

jdevcs reviewed Nov 7, 2024

View reviewed changes

fix: specify the exact lint errors

1450b8b

Conversation

krzysu commented Oct 17, 2024

Description

Type of change

Checklist:

Uh oh!

github-actions bot commented Oct 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Stats

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Benchmark

Uh oh!

codecov bot commented Oct 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

krzysu commented Nov 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jdevcs commented Nov 7, 2024

Uh oh!

jdevcs commented Nov 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot left a comment •

edited

Loading

codecov bot commented Oct 17, 2024 •

edited

Loading

krzysu commented Nov 6, 2024 •

edited

Loading