This repository was archived by the owner on Mar 5, 2025. It is now read-only.
fix: ensure contractInstance.subscriptionManager.subscribe is not throwing#7327
Merged
Muhammad-Altabba merged 6 commits into4.xfrom Oct 21, 2024
Merged
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: aefb2f8 | Previous: fab66e9 | Ratio |
|---|---|---|---|
processingTx |
22361 ops/sec (±6.60%) |
22533 ops/sec (±6.62%) |
1.01 |
processingContractDeploy |
40421 ops/sec (±7.38%) |
39420 ops/sec (±7.63%) |
0.98 |
processingContractMethodSend |
16498 ops/sec (±8.97%) |
16012 ops/sec (±7.57%) |
0.97 |
processingContractMethodCall |
28896 ops/sec (±6.61%) |
27328 ops/sec (±7.22%) |
0.95 |
abiEncode |
45680 ops/sec (±6.97%) |
42745 ops/sec (±7.84%) |
0.94 |
abiDecode |
30541 ops/sec (±8.91%) |
29680 ops/sec (±8.64%) |
0.97 |
sign |
1552 ops/sec (±3.60%) |
1484 ops/sec (±3.35%) |
0.96 |
verify |
372 ops/sec (±0.63%) |
364 ops/sec (±0.49%) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7327 +/- ##
=======================================
Coverage 94.45% 94.45%
=======================================
Files 216 217 +1
Lines 8470 8483 +13
Branches 2341 2343 +2
=======================================
+ Hits 8000 8013 +13
Misses 470 470
Flags with carried forward coverage won't be shown. Click here to find out more. |
avkos
approved these changes
Oct 18, 2024
2fbc33a to
c8291f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6288
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.