This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 7c43f75 | Previous: 7008e5c | Ratio |
|---|---|---|---|
processingTx |
23891 ops/sec (±6.14%) |
21737 ops/sec (±7.03%) |
0.91 |
processingContractDeploy |
40543 ops/sec (±7.21%) |
40986 ops/sec (±5.05%) |
1.01 |
processingContractMethodSend |
16602 ops/sec (±8.91%) |
16967 ops/sec (±6.53%) |
1.02 |
processingContractMethodCall |
28424 ops/sec (±6.31%) |
28544 ops/sec (±6.19%) |
1.00 |
abiEncode |
44946 ops/sec (±8.00%) |
44403 ops/sec (±6.90%) |
0.99 |
abiDecode |
31480 ops/sec (±7.28%) |
31413 ops/sec (±5.50%) |
1.00 |
sign |
1585 ops/sec (±0.95%) |
1547 ops/sec (±3.80%) |
0.98 |
verify |
366 ops/sec (±0.79%) |
369 ops/sec (±0.66%) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7320 +/- ##
=======================================
Coverage 94.44% 94.45%
=======================================
Files 216 216
Lines 8463 8469 +6
Branches 2340 2341 +1
=======================================
+ Hits 7993 7999 +6
Misses 470 470
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
Author
|
will also update docs + changelog |
krzysu
approved these changes
Oct 11, 2024
avkos
approved these changes
Oct 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7303
adds ignoregaspricing so contracts or sending transactions through web3.eth will not be autofill gas.
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.