This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: d4abafb | Previous: f701406 | Ratio |
|---|---|---|---|
processingTx |
21202 ops/sec (±7.78%) |
22830 ops/sec (±7.43%) |
1.08 |
processingContractDeploy |
37309 ops/sec (±6.28%) |
39939 ops/sec (±7.35%) |
1.07 |
processingContractMethodSend |
14624 ops/sec (±9.64%) |
15792 ops/sec (±6.76%) |
1.08 |
processingContractMethodCall |
26543 ops/sec (±5.83%) |
27711 ops/sec (±6.25%) |
1.04 |
abiEncode |
41231 ops/sec (±6.99%) |
42219 ops/sec (±7.33%) |
1.02 |
abiDecode |
29259 ops/sec (±6.42%) |
29744 ops/sec (±7.55%) |
1.02 |
sign |
1505 ops/sec (±1.22%) |
1498 ops/sec (±3.49%) |
1.00 |
verify |
354 ops/sec (±0.76%) |
365 ops/sec (±0.60%) |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
625ab0a to
e387933
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7319 +/- ##
=======================================
Coverage 94.44% 94.44%
=======================================
Files 216 216
Lines 8463 8463
Branches 2340 2340
=======================================
Hits 7993 7993
Misses 470 470
Flags with carried forward coverage won't be shown. Click here to find out more. |
Closes #7299
e387933 to
d39d39d
Compare
7fb9636 to
cdae3b3
Compare
krzysu
reviewed
Oct 11, 2024
krzysu
reviewed
Oct 11, 2024
krzysu
approved these changes
Oct 11, 2024
Contributor
krzysu
left a comment
There was a problem hiding this comment.
Overall, a good read! 👍 I’ve left a few suggestions for improvement.
luu-alex
reviewed
Oct 11, 2024
luu-alex
approved these changes
Oct 11, 2024
avkos
approved these changes
Oct 11, 2024
Co-authored-by: Kris <605420+krzysu@users.noreply.github.com>
Co-authored-by: Alex <luu.alex98@gmail.com>
Co-authored-by: Kris <605420+krzysu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7299