This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Add Support for Nethermind and Besu 'syncing' Subscription Payload Format#7306
Merged
Add Support for Nethermind and Besu 'syncing' Subscription Payload Format#7306
Conversation
jdevcs
reviewed
Oct 7, 2024
Contributor
jdevcs
left a comment
There was a problem hiding this comment.
Thanks for contributions, plus could you also add changlog
jdevcs
approved these changes
Oct 7, 2024
Contributor
|
Will be included in next release, thanks alot :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently if I subscribe to Nethermind or Besu clients with 'syncing' subscription it throws the following error:
This is due to the response format differences. Here is an example of Besu or Nethermind response:
While a Geth node wraps the extra details into one more depth level:
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.