This repository was archived by the owner on Mar 5, 2025. It is now read-only.
fix(onNewProviderDiscovered): callback-parameter#7242
Merged
Conversation
Callback for `onNewProviderDiscovered`should have `EIP6963ProvidersMapUpdateEvent` parameter Closes #7241
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller
Unchanged
|
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: c177665 | Previous: 2f24244 | Ratio |
|---|---|---|---|
processingTx |
21833 ops/sec (±7.86%) |
23756 ops/sec (±7.52%) |
1.09 |
processingContractDeploy |
36691 ops/sec (±10.24%) |
40022 ops/sec (±7.39%) |
1.09 |
processingContractMethodSend |
14680 ops/sec (±10.24%) |
16888 ops/sec (±7.21%) |
1.15 |
processingContractMethodCall |
25209 ops/sec (±9.54%) |
27258 ops/sec (±8.42%) |
1.08 |
abiEncode |
42100 ops/sec (±5.71%) |
44502 ops/sec (±6.85%) |
1.06 |
abiDecode |
28208 ops/sec (±10.91%) |
31804 ops/sec (±6.33%) |
1.13 |
sign |
1491 ops/sec (±3.98%) |
1546 ops/sec (±4.08%) |
1.04 |
verify |
363 ops/sec (±0.60%) |
372 ops/sec (±0.57%) |
1.02 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7242 +/- ##
=======================================
Coverage 94.48% 94.48%
=======================================
Files 216 216
Lines 8439 8439
Branches 2318 2318
=======================================
Hits 7974 7974
Misses 465 465
Flags with carried forward coverage won't be shown. Click here to find out more. |
jdevcs
approved these changes
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callback for
onNewProviderDiscoveredshould haveEIP6963ProvidersMapUpdateEventparameterCloses #7241