This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Merged
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 3c63d60 | Previous: 280b8f0 | Ratio |
|---|---|---|---|
processingTx |
8625 ops/sec (±4.09%) |
8643 ops/sec (±4.01%) |
1.00 |
processingContractDeploy |
39880 ops/sec (±6.28%) |
37706 ops/sec (±7.16%) |
0.95 |
processingContractMethodSend |
15338 ops/sec (±7.96%) |
15011 ops/sec (±8.43%) |
0.98 |
processingContractMethodCall |
26490 ops/sec (±8.22%) |
26199 ops/sec (±7.75%) |
0.99 |
abiEncode |
41269 ops/sec (±6.92%) |
40879 ops/sec (±7.43%) |
0.99 |
abiDecode |
29817 ops/sec (±6.41%) |
30556 ops/sec (±6.68%) |
1.02 |
sign |
1490 ops/sec (±3.79%) |
1503 ops/sec (±3.72%) |
1.01 |
verify |
367 ops/sec (±0.78%) |
363 ops/sec (±0.57%) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7138 +/- ##
=======================================
Coverage 94.44% 94.45%
=======================================
Files 215 215
Lines 8366 8379 +13
Branches 2304 2310 +6
=======================================
+ Hits 7901 7914 +13
Misses 465 465
Flags with carried forward coverage won't be shown. Click here to find out more. |
avkos
approved these changes
Jul 4, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#7134
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.