This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 35dd584 | Previous: e9fc019 | Ratio |
|---|---|---|---|
processingTx |
9142 ops/sec (±3.33%) |
9175 ops/sec (±3.95%) |
1.00 |
processingContractDeploy |
39843 ops/sec (±7.98%) |
38902 ops/sec (±6.92%) |
0.98 |
processingContractMethodSend |
15411 ops/sec (±9.17%) |
15550 ops/sec (±7.85%) |
1.01 |
processingContractMethodCall |
27836 ops/sec (±6.82%) |
27222 ops/sec (±8.01%) |
0.98 |
abiEncode |
43246 ops/sec (±9.23%) |
43564 ops/sec (±6.49%) |
1.01 |
abiDecode |
30823 ops/sec (±6.07%) |
30187 ops/sec (±7.32%) |
0.98 |
sign |
1528 ops/sec (±3.69%) |
1545 ops/sec (±0.67%) |
1.01 |
verify |
366 ops/sec (±0.95%) |
367 ops/sec (±0.61%) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7124 +/- ##
==========================================
+ Coverage 93.98% 94.45% +0.46%
==========================================
Files 215 215
Lines 8335 8387 +52
Branches 2301 2313 +12
==========================================
+ Hits 7834 7922 +88
+ Misses 501 465 -36
Flags with carried forward coverage won't be shown. Click here to find out more. |
Muhammad-Altabba
approved these changes
Jun 25, 2024
jdevcs
approved these changes
Jul 8, 2024
luu-alex
approved these changes
Jul 8, 2024
Merged
This was referenced Sep 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.