This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Merged
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 9d13f89 | Previous: 6c075db | Ratio |
|---|---|---|---|
processingTx |
9174 ops/sec (±3.66%) |
9301 ops/sec (±4.81%) |
1.01 |
processingContractDeploy |
38542 ops/sec (±8.11%) |
39129 ops/sec (±7.62%) |
1.02 |
processingContractMethodSend |
19375 ops/sec (±7.10%) |
19443 ops/sec (±5.19%) |
1.00 |
processingContractMethodCall |
40603 ops/sec (±5.89%) |
38971 ops/sec (±6.34%) |
0.96 |
abiEncode |
45123 ops/sec (±7.11%) |
44252 ops/sec (±6.92%) |
0.98 |
abiDecode |
30736 ops/sec (±7.86%) |
30419 ops/sec (±8.89%) |
0.99 |
sign |
1561 ops/sec (±3.32%) |
1656 ops/sec (±4.08%) |
1.06 |
verify |
381 ops/sec (±0.45%) |
373 ops/sec (±0.78%) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
avkos
approved these changes
May 1, 2024
This was referenced Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.