This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Conversation
17 tasks
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 0e5d13a | Previous: 6c075db | Ratio |
|---|---|---|---|
processingTx |
9211 ops/sec (±4.46%) |
9301 ops/sec (±4.81%) |
1.01 |
processingContractDeploy |
39411 ops/sec (±5.89%) |
39129 ops/sec (±7.62%) |
0.99 |
processingContractMethodSend |
19802 ops/sec (±8.47%) |
19443 ops/sec (±5.19%) |
0.98 |
processingContractMethodCall |
41054 ops/sec (±5.12%) |
38971 ops/sec (±6.34%) |
0.95 |
abiEncode |
45968 ops/sec (±6.97%) |
44252 ops/sec (±6.92%) |
0.96 |
abiDecode |
31218 ops/sec (±7.26%) |
30419 ops/sec (±8.89%) |
0.97 |
sign |
1630 ops/sec (±0.72%) |
1656 ops/sec (±4.08%) |
1.02 |
verify |
380 ops/sec (±0.65%) |
373 ops/sec (±0.78%) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7011 +/- ##
=======================================
Coverage 91.98% 91.98%
=======================================
Files 215 215
Lines 8284 8284
Branches 2273 2273
=======================================
Hits 7620 7620
Misses 664 664
Flags with carried forward coverage won't be shown. Click here to find out more.
|
avkos
approved these changes
Apr 29, 2024
luu-alex
approved these changes
Apr 30, 2024
This was referenced Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the missing types to the ”accounts“
#6762
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.