Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Reduce some CI/CD tests#6698

Merged
Muhammad-Altabba merged 14 commits into4.xfrom
6684-v4-tests-github-ci-actions-update
Jan 15, 2024
Merged

Reduce some CI/CD tests#6698
Muhammad-Altabba merged 14 commits into4.xfrom
6684-v4-tests-github-ci-actions-update

Conversation

@Muhammad-Altabba
Copy link
Contributor

@Muhammad-Altabba Muhammad-Altabba commented Jan 8, 2024 •
edited
Loading

Description

Fixes #6684

To work with node 20, HardHat needed to be updated.
And a test failing for geth has been fixed but with a follow up issue: #6700

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@Muhammad-Altabba Muhammad-Altabba linked an issue Jan 8, 2024 that may be closed by this pull request
v4 Tests - Github CI Actions Update #6684
Closed
@github-actions
Copy link

github-actions bot commented Jan 8, 2024

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 618 KB 618 KB 0 0.00%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 601 KB 601 KB 0 0.00%
../lib/commonjs/index.d.ts 8.63 KB 8.63 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.89 KB 3.89 KB 0 0.00%
../lib/commonjs/types.d.ts 2.45 KB 2.45 KB 0 0.00%
../lib/commonjs/web3.d.ts 1.14 KB 1.14 KB 0 0.00%
../lib/commonjs/abi.d.ts 999 bytes 999 bytes 0 0.00%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

@github-actions
Copy link

github-actions bot commented Jan 8, 2024 •
edited
Loading

Benchmark

Benchmark suite Current: 60b1cce Previous: 6c075db Ratio
processingTx 9176 ops/sec (±5.16%) 9301 ops/sec (±4.81%) 1.01
processingContractDeploy 42692 ops/sec (±6.18%) 39129 ops/sec (±7.62%) 0.92
processingContractMethodSend 20517 ops/sec (±6.10%) 19443 ops/sec (±5.19%) 0.95
processingContractMethodCall 41711 ops/sec (±5.34%) 38971 ops/sec (±6.34%) 0.93
abiEncode 48234 ops/sec (±6.03%) 44252 ops/sec (±6.92%) 0.92
abiDecode 31773 ops/sec (±8.43%) 30419 ops/sec (±8.89%) 0.96
sign 1690 ops/sec (±2.86%) 1656 ops/sec (±4.08%) 0.98
verify 395 ops/sec (±0.56%) 373 ops/sec (±0.78%) 0.94

This comment was automatically generated by workflow using github-action-benchmark.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 8, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 60b1cce
Status: ✅  Deploy successful!
Preview URL: https://a631493e.web3-js-docs.pages.dev
Branch Preview URL: https://6684-v4-tests-github-ci-acti.web3-js-docs.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jan 8, 2024 •
edited
Loading

Codecov Report

Merging #6698 (60b1cce) into 4.x (1eb07d1) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##              4.x    #6698   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files         214      214           
  Lines        8171     8171           
  Branches     2200     2200           
=======================================
  Hits         7520     7520           
  Misses        651      651
Flag Coverage Δ
UnitTests 92.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@Muhammad-Altabba Muhammad-Altabba marked this pull request as ready for review January 8, 2024 13:36
jdevcs
jdevcs reviewed Jan 8, 2024
View reviewed changes
avkos
avkos suggested changes Jan 8, 2024
View reviewed changes
@Muhammad-Altabba Muhammad-Altabba requested a review from avkos January 8, 2024 19:41
avkos
avkos reviewed Jan 9, 2024
View reviewed changes
@Muhammad-Altabba Muhammad-Altabba merged commit a3fe342 into 4.x Jan 15, 2024
@Muhammad-Altabba Muhammad-Altabba deleted the 6684-v4-tests-github-ci-actions-update branch January 15, 2024 13:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@luu-alex luu-alex Awaiting requested review from luu-alex

2 more reviewers

@avkos avkos avkos approved these changes

@jdevcs jdevcs jdevcs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v4 Tests - Github CI Actions Update

3 participants

@Muhammad-Altabba @avkos @jdevcs