Add regionCode test (manual and idl)#9706
Conversation
Build PASSEDStarted: 2018-02-28 06:21:35 View more information about this build on: |
|
@rsolomakhin, would like your ok on these. |
There was a problem hiding this comment.
LGTM although @rsolomakhin would be in a better position to confirm that this exactly matches Chrome's user input -> regionCode translation algorithm.
EDIT: oops, I totally misread my email and thought you were asking for me. Yes, please, let's have @rsolomakhin confirm :)
|
np! thanks for checking them @domenic! |
rsolomakhin
left a comment
There was a problem hiding this comment.
Ping @sebsg to take a look.
| region: '', | ||
| city: 'Kabul', | ||
| country: 'AU', | ||
| regionCode: 'AU-QLD', |
There was a problem hiding this comment.
@sebsg: Is this what Australian region codes look like? (I expected only QLD without AU-, but you know better.)
There was a problem hiding this comment.
See, for example https://en.m.wikipedia.org/wiki/ISO_3166-2:AU
There was a problem hiding this comment.
Check out the Portuguese ones... they are numbered. Super interesting: https://en.m.wikipedia.org/wiki/ISO_3166-2:PT
(I was going to use Portuguese ones originally, but they gave too much “saudade” 😭🇵🇹)
There was a problem hiding this comment.
I was under that impression too, but it seems like it's like that everywhere. "US-CA" for example. I think it's because a few use numbers like marcoscaceres mentionned and they need to be unique.
rsolomakhin
left a comment
There was a problem hiding this comment.
LGTM. Although we store without AU- prefix internally, we can add the <country-code>- prefix for all region codes.
Sounds good as long as it conforms to the ISO standard. |
tests for w3c/payment-request#690