Remove tests for, and test the removal of, context menus#6167
Remove tests for, and test the removal of, context menus#6167sideshowbarker merged 4 commits intomasterfrom
Conversation
Firefox (nightly)Testing web-platform-tests at revision fabf1b3 |
Sauce (safari)Testing web-platform-tests at revision fabf1b3 |
Chrome (unstable)Testing web-platform-tests at revision fabf1b3 |
Sauce (MicrosoftEdge)Testing web-platform-tests at revision fabf1b3 |
| assert_false("onshow" in location, | ||
| `${location.constructor.name} must not have a property "onshow"`); | ||
| } | ||
| assert_false("onshow" in Element.prototype, `Element.prototype must not contain an "onshow" property`); |
There was a problem hiding this comment.
Why is this not in the array instead?
Maybe also test HTMLDocument.prototype.
| assert_false("contextMenu" in HTMLElement.prototype, | ||
| "HTMLElement's prototype must not have a property \"contextmenu\""); | ||
| assert_false("contextMenu" in document.createElement("div"), | ||
| "A div must not have a property \"contextmenu\""); |
| }, "menu.label must not be present"); | ||
|
|
||
| test(() => { | ||
| console.log(document.querySelectorAll("menuitem:enabled")); |
|
|
||
| test(() => { | ||
| assert_equals(getComputedStyle(menu).display, "block"); | ||
| }, "The user-agent stylesheet must type=\"context\" menus as block display"); |
There was a problem hiding this comment.
This sentence is missing some word
| }, "el.contextMenu must not be present"); | ||
|
|
||
| test(() => { | ||
| assert_false("type" in menu); |
There was a problem hiding this comment.
Also test that setting type does not set a content attribute (and similarly for the others).
|
I fixed the conformance checker tests and filed validator/validator#526 |
cffaafe to
f63325d
Compare
thanks |
|
There doesn't seem to be any documentation about why this was merged despite failing the test jobs on all browsers? |
Follows whatwg/html#2742.
Bugs to file:
@sideshowbarker, there are some conformance checker tests for menuitem, but I think they are testing invalid cases which stay invalid; would appreciate your help checking those.