Attempt to clean up the WPT export of popover=hint from Chromium to WPT#59955
Merged
Conversation
This PR pushes the latest state of `popover=hint` tests from Chromium (prior to the landing of https://crrev.com/c/7851723, which was a temporary stopgap to unbreak the infra) to WPT. This one PR should completely replace any PRs that come out of any still-unlanded PRs in this list: whatwg/html#12345 (comment)
Contributor
Author
|
@jakearchibald to review |
11 tasks
jakearchibald
approved these changes
May 19, 2026
jakearchibald
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for getting these together!
| // Note: this should *not* reset "hint stack parent". | ||
| assert_true(p34.matches(':popover-open'), 'p34 should remain open'); | ||
| assert_false(p35.matches(':popover-open'), 'p35 should be light dismissed'); | ||
| assert_true(p36.matches(':popover-open'), 'p36 should remain open, because its ancestor p34 is still open'); |
Contributor
There was a problem hiding this comment.
Suggested change
| assert_true(p36.matches(':popover-open'), 'p36 should remain open, because its ancestor p34 is still open'); | |
| assert_true(p36.matches(':popover-open'), 'p36 should remain open, because it was clicked'); |
It isn't left open just because its ancestor is open. Otherwise, you could make the same case for p35 being open.
Contributor
Author
There was a problem hiding this comment.
I updated the descriptions of this and the one before it. PTAL.
jgraham
approved these changes
May 21, 2026
jgraham
left a comment
Contributor
There was a problem hiding this comment.
I'm going to approve on behalf of Interop; I believe the changes here have buy in from all vendors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR pushes the latest state of
popover=hinttests from Chromium (prior to the landing of https://crrev.com/c/7851723, which was a temporary stopgap to unbreak the infra) to WPT.This one PR should completely replace any PRs that come out of any still-unlanded PRs in this list:
whatwg/html#12345 (comment)
Change-Id: I363b411aa8f6979fbde3766c27afe229703dfc1f
Change-Id: Ibd6af063310585b9044de63a06e36ffd79d011d4
Change-Id: I917bf939614f9811470444e9f13c942e5c63b1b1