Skip to content

Add tests for text modules#56812

Open
eemeli wants to merge 8 commits intoweb-platform-tests:masterfrom
eemeli:import-text
Open

Add tests for text modules#56812
eemeli wants to merge 8 commits intoweb-platform-tests:masterfrom
eemeli:import-text

Conversation

@eemeli
Copy link
Copy Markdown

@eemeli eemeli commented Dec 17, 2025 •
edited
Loading

This is to support the spec changes in:

I've effectively tried to duplicate and appropriately modify all the tests for JSON modules that I was able to find.

This was referenced Dec 17, 2025
Open
Open
Open
@bakkot
Copy link
Copy Markdown
Contributor

bakkot commented Dec 17, 2025

Might consider adding a test that the request has a Sec-Fetch-Dest: text header. I think this is lacking for JSON as well, and have it on my backlog to write such a test, but as long as you're here...

Also, you could add a test that importing a module as JS, from a server which responds with valid JS file with a content type of text/javascript (and so loading succeeds), and then fetching it again with type: "text" causes two network requests (because the type is part of the module map). This is similar to repeated-imports.any.js but the other way around.

@eemeli
Copy link
Copy Markdown
Author

eemeli commented Dec 20, 2025

Might consider adding a test that the request has a Sec-Fetch-Dest: text header. I think this is lacking for JSON as well, and have it on my backlog to write such a test, but as long as you're here...

Done. There are some test for the JSON module fetch headers already at fetch/metadata/tools/templates/script-json-module-import-static.sub.html; I added corresponding ones for text modules, as well as a non-generated test modeled after the audioworklet test.

Also, you could add a test that importing a module as JS, from a server which responds with valid JS file with a content type of text/javascript (and so loading succeeds), and then fetching it again with type: "text" causes two network requests (because the type is part of the module map). This is similar to repeated-imports.any.js but the other way around.

Done; added those to repeated-imports.any.js.

@eemeli eemeli requested a review from bakkot December 20, 2025 10:01
@bakkot
Copy link
Copy Markdown
Contributor

bakkot commented Dec 20, 2025

New tests look great, thanks.

@bakkot bakkot mentioned this pull request Dec 22, 2025
Closed
8 tasks
@eemeli eemeli mentioned this pull request Mar 3, 2026
Open
@eemeli eemeli requested a review from annevk March 12, 2026 22:42
annevk
annevk approved these changes Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me. I didn't verify every line though.

zcorpan
zcorpan approved these changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@zcorpan zcorpan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage looks good. There are merge conflicts though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zcorpan zcorpan zcorpan approved these changes

@annevk annevk annevk approved these changes

@andypaicu andypaicu Awaiting requested review from andypaicu

@foolip foolip Awaiting requested review from foolip

@hillbrad hillbrad Awaiting requested review from hillbrad

@hiroshige-g hiroshige-g Awaiting requested review from hiroshige-g

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@mnot mnot Awaiting requested review from mnot

@snuggs snuggs Awaiting requested review from snuggs

@yoavweiss yoavweiss Awaiting requested review from yoavweiss

@youennf youennf Awaiting requested review from youennf

@yutakahirano yutakahirano Awaiting requested review from yutakahirano

@iVanlIsh iVanlIsh Awaiting requested review from iVanlIsh

@mikewest mikewest Awaiting requested review from mikewest

@bakkot bakkot Awaiting requested review from bakkot

Assignees

@yutakahirano yutakahirano

Labels

content-security-policy fetch html preload wg-s_webperf

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@eemeli @bakkot @zcorpan @annevk @yutakahirano @wpt-pr-bot