html: The queued <media> volumechange event should be cancellable
#56139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 20, 2025
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
fb3c3b6 to
4e7abcf
Compare
Following the HTML specification, on the `volume` or `mute` attrubute changes the user agent must queue a media element task given the media element to fire an event named `volumechange` at the media element (the `generation_id` value will be captured to allow cancel this task - `media-element-load-algorithm` steps 3-5) See https://html.spec.whatwg.org/multipage/#event-media-volumechange See https://html.spec.whatwg.org/multipage/#media-element-load-algorithm Changed the naming of the `playbackRate` and `defaultPlaybackRate` members to match Rust naming conventions (`snake_case`). Testing: Added the `cancellable` subtest to `event_volumechange` test - html/semantics/embedded-content/media-elements/event_volumechange.html Signed-off-by: Andrei Volykhin <andrei.volykhin@gmail.com>
4e7abcf to
0e8f6df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the HTML specification, on the
volumeormuteattrubute changes the user agent must queue a media element task given the media element to fire an event namedvolumechangeat the media element (thegeneration_idvalue will be captured to allow cancel this task -media-element-load-algorithmsteps 3-5)See https://html.spec.whatwg.org/multipage/#event-media-volumechange
See https://html.spec.whatwg.org/multipage/#media-element-load-algorithm
Changed the naming of the
playbackRateanddefaultPlaybackRatemembers to match Rust naming conventions (snake_case).Testing: Added the
cancellablesubtest toevent_volumechangetestReviewed in servo/servo#40763