[Gecko Bug 1979915] Part 2 - Update text expectations for implementing text-decoration-trim#55303
Merged
moz-wptsync-bot merged 1 commit intomasterfrom Oct 8, 2025
Merged
[Gecko Bug 1979915] Part 2 - Update text expectations for implementing text-decoration-trim#55303moz-wptsync-bot merged 1 commit intomasterfrom
moz-wptsync-bot merged 1 commit intomasterfrom
Conversation
This adjusts two of the WPT where skip-ink could cause problems with the descenders when just shifting the text. There are still multiple tests that check that skip-ink functions correctly, both for negative and positive trim values, though not for BIDI text. Differential Revision: https://phabricator.services.mozilla.com/D267688 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1979915 gecko-commit: 5013885993a2de7649bfb087484f28eed59bb4a7 gecko-reviewers: layout-jp-market-reviewers, jfkthame, TYLin
wpt-pr-bot
approved these changes
Oct 8, 2025
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adjusts two of the WPT where skip-ink could cause problems with the
descenders when just shifting the text.
There are still multiple tests that check that skip-ink functions correctly,
both for negative and positive trim values, though not for BIDI text.
Differential Revision: https://phabricator.services.mozilla.com/D267688
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1979915
gecko-commit: 5013885993a2de7649bfb087484f28eed59bb4a7
gecko-reviewers: layout-jp-market-reviewers, jfkthame, TYLin