Skip to content

URL: add path setter tests for parent directory#53745

Merged
domenic merged 1 commit intoweb-platform-tests:masterfrom
watilde:test/url-path-setter
Jul 14, 2025
Merged

URL: add path setter tests for parent directory#53745
domenic merged 1 commit intoweb-platform-tests:masterfrom
watilde:test/url-path-setter

Conversation

@watilde
Copy link
Contributor

@watilde watilde commented Jul 13, 2025

I found out a gap between WHATWG's URL and Node.js as the below and add the test to capture it.

const NodeURL = require("url").URL;
const WhatwgURL = require("../whatwg-url/").URL;
const newPath = '/..';

const url = new NodeURL("foo://path/to");  
url.pathname = newPath;
console.log(url.href); // => foo://path

const url2 = new WhatwgURL("foo://path/to");
url2.pathname = newPath;
console.log(url2.href); // => foo://path/

@wpt-pr-bot wpt-pr-bot added the url label Jul 13, 2025
@domenic domenic merged commit 17f9cb9 into web-platform-tests:master Jul 14, 2025
25 checks passed
@watilde watilde deleted the test/url-path-setter branch July 14, 2025 04:57
@anonrig anonrig mentioned this pull request Jul 15, 2025
Closed
@watilde watilde mentioned this pull request Jan 6, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domenic domenic domenic approved these changes

@annevk annevk Awaiting requested review from annevk

@mikewest mikewest Awaiting requested review from mikewest

@TimothyGu TimothyGu Awaiting requested review from TimothyGu

Assignees

@domenic domenic

Labels

url

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@watilde @domenic @wpt-pr-bot