Skip to content

[selectors] Test :heading and :heading()#53440

Merged
zcorpan merged 5 commits intomasterfrom
zcorpan/heading-pseudo
Aug 11, 2025
Merged

[selectors] Test :heading and :heading()#53440
zcorpan merged 5 commits intomasterfrom
zcorpan/heading-pseudo

Conversation

@zcorpan
Copy link
Copy Markdown
Member

@zcorpan zcorpan commented Jun 27, 2025

@zcorpan zcorpan requested a review from keithamus June 27, 2025 13:52
@zcorpan zcorpan mentioned this pull request Jun 27, 2025
Merged
6 tasks
keithamus
keithamus reviewed Jun 28, 2025
View reviewed changes
@zcorpan @keithamus
Apply suggestions from code review
1530b7c 
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
keithamus
keithamus reviewed Jun 28, 2025
View reviewed changes
keithamus
keithamus reviewed Jun 29, 2025
View reviewed changes
@community-tc-integration
Copy link
Copy Markdown

community-tc-integration bot commented Jun 30, 2025

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Pc6PXcArTsmtDafeHUrqqg/IxGgf0MtT_mvtpau-45BPg",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Pc6PXcArTsmtDafeHUrqqg"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Pc6PXcArTsmtDafeHUrqqg/IxGgf0MtT_mvtpau-45BPg",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Pc6PXcArTsmtDafeHUrqqg"
      ]
    }
  ]
}
  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-06-30T10:40:52.137Z

@community-tc-integration
Copy link
Copy Markdown

community-tc-integration bot commented Jun 30, 2025

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Pc6PXcArTsmtDafeHUrqqg/JRZhsx_eS-2Uwq_j2cYEwg",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Pc6PXcArTsmtDafeHUrqqg"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Pc6PXcArTsmtDafeHUrqqg/JRZhsx_eS-2Uwq_j2cYEwg",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Pc6PXcArTsmtDafeHUrqqg"
      ]
    }
  ]
}
  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-06-30T10:40:52.424Z

@zcorpan zcorpan closed this Aug 4, 2025
@zcorpan zcorpan reopened this Aug 4, 2025
@zcorpan
Copy link
Copy Markdown
Member Author

zcorpan commented Aug 4, 2025

Thanks for the fixes and review @keithamus ! Looks good.

@keithamus keithamus requested a review from annevk August 6, 2025 13:40
annevk
annevk approved these changes Aug 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I do wonder whether these should be in css/selectors or html/ somewhere. The latter would make a little bit more sense to me as CSS is supposed to be host-agnostic, despite that being some weird form of fiction. I suspect we're rather inconsistent about it at the moment.

@zcorpan @annevk
Apply suggestion from @annevk
442b8ba 
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
@zcorpan
Copy link
Copy Markdown
Member Author

zcorpan commented Aug 8, 2025

css/selectors seems to contain various tests with HTML-specific expectations already. But https://wpt.fyi/results/html/semantics/selectors/pseudo-classes also exists. @tabatkins do you have an opinion about where to put these?

@annevk
Copy link
Copy Markdown
Member

annevk commented Aug 8, 2025

I'm okay with you landing this and later sorting it out. The problem already existed and we do need to deal with it, but I don't want to block momentum on this small feature.

@zcorpan zcorpan merged commit 7ed8a20 into master Aug 11, 2025
25 checks passed
@zcorpan zcorpan deleted the zcorpan/heading-pseudo branch August 11, 2025 23:31
@keithamus keithamus mentioned this pull request Aug 13, 2025
Merged
@zcorpan zcorpan mentioned this pull request Sep 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keithamus keithamus keithamus approved these changes

@annevk annevk annevk approved these changes

@fantasai fantasai Awaiting requested review from fantasai

@frivoal frivoal Awaiting requested review from frivoal

@plinss plinss Awaiting requested review from plinss

@tabatkins tabatkins Awaiting requested review from tabatkins

Assignees

@fantasai fantasai

Labels

selectors wg-css

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zcorpan @annevk @keithamus @fantasai @wpt-pr-bot