Digital Credentials: Add userAgentAllowsProtocol method#53089
Merged
Conversation
9 tasks
| <script type="module"> | ||
|
|
||
| promise_test(async (t) => { | ||
| const result = DigitalCredential.clientAllowsProtocol('protocol.banana'); |
Contributor
There was a problem hiding this comment.
This should have a bunch of failure cases. For example:
const invalidIdentifiers = ["", " ", "a b", "a,b", "AB", "a.B", "a.b", " foo-bar", " foo-bar ", "foo-bar "];
for (const invalidIdentifier of invalidIdentifiers) {
const result = DigitalCredential.allowsProtocol(invalidIdentifier);
assert_equals(result, false, `Incorrect result for ${invalidIdentifier}.`);
}
mohamedamir
reviewed
Jun 12, 2025
Contributor
|
Please make sure to update the commit message 🙏 |
mohamedamir
reviewed
Jun 12, 2025
mohamedamir
approved these changes
Jun 26, 2025
mohamedamir
left a comment
Contributor
There was a problem hiding this comment.
Looks great!
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test for w3c-fedid/digital-credentials#221
Also updates spec links after WICG to WG move and adds Tim as suggested reviewer.