[align] Fix auto-margins disabling justify-self sizing.#52550
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom May 14, 2025
Merged
[align] Fix auto-margins disabling justify-self sizing.#52550chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
This patch changes our behaviour to be in line with: w3c/csswg-drafts#12102 (comment) This remove the `has_auto_margins` guards when choosing how an auto inline-size should resolve. Bug: 417730391 Change-Id: I06e831e3266f3f4a965b715fce12523ead938015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6547880 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1460370}
wpt-pr-bot
approved these changes
May 14, 2025
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This was referenced May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch changes our behaviour to be in line with:
w3c/csswg-drafts#12102 (comment)
This remove the
has_auto_marginsguards when choosing how anauto inline-size should resolve.
Bug: 417730391
Change-Id: I06e831e3266f3f4a965b715fce12523ead938015
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6547880
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1460370}