[Sanitizer] Add parseHTML testcases, and fix DOCTYPE handling.#52406
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom May 9, 2025
Merged
[Sanitizer] Add parseHTML testcases, and fix DOCTYPE handling.#52406chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
Add WPT testcases for parseHTML + parseHTMLUnsafe. Fix <!DOCTYPE> handling, as a follow-up to issue #288 / PR #285. Previously, it was assumed Doc-Type nodes couldn't make it into the sanitizer implementation; but with the change to parseHTML context they can. Spec: WICG/sanitizer-api#288 Spec: WICG/sanitizer-api#285 Bug: 356601280 Change-Id: Iec797b929eb3b90d5f08318bb28964d2f683acb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6523521 Reviewed-by: Yifan Luo <lyf@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/main@{#1457595}
wpt-pr-bot
approved these changes
May 8, 2025
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add WPT testcases for parseHTML + parseHTMLUnsafe.
Fix <!DOCTYPE> handling, as a follow-up to issue #288 / PR #285.
Previously, it was assumed Doc-Type nodes couldn't make it into
the sanitizer implementation; but with the change to parseHTML
context they can.
Spec: WICG/sanitizer-api#288
Spec: WICG/sanitizer-api#285
Bug: 356601280
Change-Id: Iec797b929eb3b90d5f08318bb28964d2f683acb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6523521
Reviewed-by: Yifan Luo <lyf@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1457595}