add two crash-tests for dialog requestClose#52020
Merged
keithamus merged 1 commit intoweb-platform-tests:masterfrom Apr 16, 2025
Merged
Conversation
lukewarlow
approved these changes
Apr 16, 2025
domenic
requested changes
Apr 16, 2025
Member
There was a problem hiding this comment.
Crash tests need to be named with the suffix -crash: https://web-platform-tests.org/writing-tests/crashtest.html
I guess maybe there is a -1 that violates this?
Member
There was a problem hiding this comment.
Good catch, there isn't a -1.
Member
Author
There was a problem hiding this comment.
Thanks for pointing this out @domenic. I've renamed the files accordingly.
96acaee to
5629a58
Compare
domenic
approved these changes
Apr 16, 2025
This was referenced Apr 16, 2025
Dialog requestClose causes several issues with regard to interplay of CloseWatcher
whatwg/html#11230
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two crash tests that can invoke crashes in Chrome; using a disconnected dialog, and a dialog connected to a document with no browsing context.