Update obsolete Scoped Custom Element Registry tests#51889
Merged
Conversation
domenic
reviewed
Apr 8, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Update tests that don't appear to duplicate the "Revamped" tests to match the new API surface. The remainder are removed. Historical tests are added at the same time for features we decided not to standardize. Also remove some historical tests that have coverage elsewhere.
944929b to
d9d82bc
Compare
6 tasks
rniwa
reviewed
Apr 8, 2025
| </script> | ||
|
|
||
| </body> |
Contributor
There was a problem hiding this comment.
This seems like unrelated change?
rniwa
reviewed
Apr 8, 2025
| @@ -214,4 +214,3 @@ | |||
| }, 'Elements in the "owner" window of a scoped registry are not always upgraded first'); | |||
|
|
|||
| </script> | |||
| </body> | |||
rniwa
reviewed
Apr 8, 2025
| @@ -101,4 +101,3 @@ | |||
| }, 'Scoped Custom element registry getters do not resolve globally registered classes from whenDefined'); | |||
|
|
|||
| </script> | |||
| </body> | |||
rniwa
approved these changes
Apr 8, 2025
domenic
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update tests that don't appear to duplicate the "Revamped" tests to
match the new API surface.
The remainder are removed.
Historical tests are added at the same time for features we decided not
to standardize. Also remove some historical tests that have coverage
elsewhere.