Revert of Don't create layout objects for children of display-none iframes. (patchset #31 id:650001 of https://codereview.chromium.org/2564633002/ ) #4888
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Feb 16, 2017
Conversation
…rames. (patchset #31 id:650001 of https://codereview.chromium.org/2564633002/ ) Reason for revert: Suspect for webkit_tests leak failures (https://crbug.com/692872). See bug for details. Original issue's description: > Don't create layout objects for children of display-none iframes. > > Most of this CL is plumbing for FrameOwnerProperties. Interesting changes: > * LayoutView can no longer have children if its FrameOwner is "DisplayNone". > * A local frame is "DisplayNone" if and only if it has no widget [which should > correspond to the actual display:none style]. > * The DisplayNone property is propagated to remote frames via > FrameOwnerProperties. > > Spec discussion: whatwg/html#1813 > > BUG=650433 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2564633002 > Cr-Commit-Position: refs/heads/master@{#450748} > Committed: https://chromium.googlesource.com/chromium/src/+/962434d34e2c9bcd17488f499515920c298b5395 TBR=esprehn@chromium.org,dcheng@chromium.org,avi@chromium.org,erikchen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=650433 Review-Url: https://codereview.chromium.org/2696283003 Cr-Commit-Position: refs/heads/master@{#450855}
Collaborator
|
Notifying @Ms2ger, @ayg, @jdm, @jgraham, @sideshowbarker, @zcorpan, and @zqzhang. (Learn how reviewing works.) |
Chrome (unstable channel)Testing web-platform-tests at revision feb0c62 All results100 tests ran/html/semantics/scripting-1/the-template-element/additions-to-serializing-xhtml-documents/outerhtml.html
/shadow-dom/untriaged/html-elements-in-shadow-trees/inert-html-elements/test-002.html
/shadow-dom/untriaged/styles/test-001.html
/html/semantics/scripting-1/the-template-element/additions-to-parsing-xhtml-documents/node-document.html
/html/semantics/scripting-1/the-template-element/additions-to-the-steps-to-clone-a-node/template-clone-children.html
/shadow-dom/untriaged/events/event-retargeting/test-003.html
/html/syntax/parsing/template/additions-to-the-in-body-insertion-mode/template-end-tag-without-start-one.html
/html/semantics/scripting-1/the-template-element/additions-to-parsing-xhtml-documents/template-child-nodes.html
/shadow-dom/untriaged/elements-and-dom-objects/shadowroot-object/shadowroot-attributes/test-010.html
/shadow-dom/untriaged/styles/test-003.html
/shadow-dom/untriaged/elements-and-dom-objects/shadowroot-object/shadowroot-attributes/test-012.html
/shadow-dom/untriaged/elements-and-dom-objects/shadowroot-object/shadowroot-methods/test-001.html
/html/semantics/scripting-1/the-template-element/definitions/template-contents-owner-test-002.html
/html/syntax/parsing/template/additions-to-the-in-body-insertion-mode/ignore-html-token.html
/html/syntax/parsing/template/additions-to-the-in-body-insertion-mode/ignore-head-token.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/window-named-properties-003.html
/html/syntax/parsing/template/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-body-context.html
/shadow-dom/untriaged/shadow-trees/reprojection/reprojection-001.html
/shadow-dom/untriaged/shadow-trees/shadow-root-001.html
/shadow-dom/untriaged/html-elements-in-shadow-trees/inert-html-elements/test-001.html
/html/syntax/parsing/template/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-context.html
/shadow-dom/untriaged/elements-and-dom-objects/extensions-to-event-interface/event-path-001.html
/shadow-dom/untriaged/html-elements-in-shadow-trees/html-forms/test-001.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/test-007.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/shadow-root-001.html
/html/syntax/parsing/template/additions-to-the-in-body-insertion-mode/ignore-frameset-token.html
/html/semantics/scripting-1/the-template-element/template-element/template-content-node-document.html
/shadow-dom/untriaged/html-elements-in-shadow-trees/html-forms/test-002.html
/shadow-dom/untriaged/user-interaction/ranges-and-selections/test-001.html
/html/syntax/parsing/template/creating-an-element-for-the-token/template-owner-document.html
/shadow-dom/untriaged/elements-and-dom-objects/shadowroot-object/shadowroot-methods/test-006.html
/html/semantics/scripting-1/the-template-element/definitions/template-contents-owner-test-001.html
/shadow-dom/untriaged/elements-and-dom-objects/shadowroot-object/shadowroot-attributes/test-013.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/window-named-properties-001.html
/html/syntax/parsing/template/additions-to-the-in-body-insertion-mode/ignore-body-token.html
/shadow-dom/untriaged/user-interaction/editing/inheritance-of-content-editable-001.html
/shadow-dom/untriaged/elements-and-dom-objects/shadowroot-object/shadowroot-attributes/test-007.html
/html/semantics/scripting-1/the-template-element/template-element/node-document-changes.html
/html/syntax/parsing/template/additions-to-the-in-frameset-insertion-mode/end-tag-frameset.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/test-009.html
/shadow-dom/untriaged/events/event-dispatch/test-003.html
/html/semantics/scripting-1/the-template-element/template-element/template-descendant-frameset.html
/html/syntax/parsing/template/additions-to-foster-parenting/template-is-not-a-foster-parent-element.html
/shadow-dom/untriaged/elements-and-dom-objects/shadowroot-object/shadowroot-methods/test-007.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/ownerdocument-001.html
/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/origin-check-in-document-open-same-origin-domain.sub.html
/shadow-dom/untriaged/html-elements-in-shadow-trees/html-forms/test-003.html
/shadow-dom/untriaged/elements-and-dom-objects/shadowroot-object/shadowroot-attributes/test-009.html
/html/syntax/parsing/template/additions-to-foster-parenting/template-is-a-foster-parent-element.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/window-named-properties-002.html
/shadow-dom/untriaged/styles/test-008.html
/shadow-dom/untriaged/elements-and-dom-objects/extensions-to-element-interface/attributes/test-006.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/selectors-api-002.html
/shadow-dom/untriaged/elements-and-dom-objects/shadowroot-object/shadowroot-methods/test-004.html
/html/syntax/parsing/template/additions-to-the-in-table-insertion-mode/end-tag-table.html
/html/semantics/scripting-1/the-template-element/innerhtml-on-templates/innerhtml.html
/html/syntax/parsing/template/additions-to-the-in-body-insertion-mode/start-tag-html.html
/shadow-dom/untriaged/shadow-trees/shadow-root-002.html
/shadow-dom/untriaged/user-interaction/ranges-and-selections/test-002.html
/shadow-dom/untriaged/user-interaction/active-element/test-002.html
/html/syntax/parsing/template/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-row-context.html
/html/semantics/scripting-1/the-template-element/additions-to-the-steps-to-clone-a-node/templates-copy-document-owner.html
/html/syntax/parsing/template/additions-to-the-in-body-insertion-mode/generating-of-implied-end-tags.html
/shadow-dom/untriaged/events/retargeting-relatedtarget/test-002.html
/shadow-dom/untriaged/elements-and-dom-objects/shadowroot-object/shadowroot-attributes/activeElement-confirm-return-null.html
/shadow-dom/untriaged/events/retargeting-focus-events/test-002.html
/html/semantics/scripting-1/the-template-element/template-element/template-as-a-descendant.html
/shadow-dom/untriaged/elements-and-dom-objects/shadowroot-object/shadowroot-attributes/test-011.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/selectors-api-001.html
/shadow-dom/untriaged/shadow-trees/nested-shadow-trees/nested_tree_reftest.html
/shadow-dom/untriaged/elements-and-dom-objects/extensions-to-element-interface/methods/test-001.html
/html/semantics/scripting-1/the-template-element/template-element/template-descendant-head.html
/shadow-dom/untriaged/events/event-dispatch/test-002.html
/shadow-dom/untriaged/user-interaction/active-element/test-001.html
/shadow-dom/untriaged/events/retargeting-focus-events/test-001.html
/html/syntax/parsing/template/additions-to-the-in-head-insertion-mode/generating-of-implied-end-tags.html
/html/semantics/scripting-1/the-template-element/template-element/template-descendant-body.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/ownerdocument-002.html
/html/semantics/scripting-1/the-template-element/definitions/template-contents.html
/shadow-dom/untriaged/elements-and-dom-objects/shadowroot-object/shadowroot-methods/test-010.html
/html/semantics/scripting-1/the-template-element/template-element/template-content.html
/html/semantics/scripting-1/the-template-element/definitions/template-contents-owner-document-type.html
/shadow-dom/untriaged/styles/not-apply-in-shadow-root-001.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/dom-tree-accessors-002.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/test-005.html
/html/semantics/scripting-1/the-template-element/serializing-html-templates/outerhtml.html
/shadow-dom/untriaged/styles/test-005.html
/shadow-dom/untriaged/events/retargeting-focus-events/test-003.html
/html/semantics/scripting-1/the-template-element/template-element/content-attribute.html
/shadow-dom/untriaged/events/retargeting-relatedtarget/test-003.html
/shadow-dom/untriaged/events/test-001.html
/html/syntax/parsing/template/additions-to-the-in-body-insertion-mode/start-tag-body.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/test-011.html
/shadow-dom/untriaged/events/event-retargeting/test-001.html
/html/syntax/parsing/template/additions-to-the-in-head-insertion-mode/template-end-tag-without-start-one.html
/shadow-dom/untriaged/elements-and-dom-objects/extensions-to-element-interface/methods/test-002.html
/html/syntax/parsing/template/appending-to-a-template/template-child-nodes.html
/shadow-dom/untriaged/events/retargeting-relatedtarget/test-001.html
/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/origin-check-in-document-open-basic.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/dom-tree-accessors-001.html
|
Firefox (nightly channel)Testing web-platform-tests at revision feb0c62 All results100 tests ran/html/semantics/scripting-1/the-template-element/additions-to-serializing-xhtml-documents/outerhtml.html
/shadow-dom/untriaged/html-elements-in-shadow-trees/inert-html-elements/test-002.html
/shadow-dom/untriaged/styles/test-001.html
/html/semantics/scripting-1/the-template-element/additions-to-parsing-xhtml-documents/node-document.html
/html/semantics/scripting-1/the-template-element/additions-to-the-steps-to-clone-a-node/template-clone-children.html
/shadow-dom/untriaged/events/event-retargeting/test-003.html
/html/syntax/parsing/template/additions-to-the-in-body-insertion-mode/template-end-tag-without-start-one.html
/html/semantics/scripting-1/the-template-element/additions-to-parsing-xhtml-documents/template-child-nodes.html
/shadow-dom/untriaged/elements-and-dom-objects/shadowroot-object/shadowroot-attributes/test-010.html
/shadow-dom/untriaged/styles/test-003.html
/shadow-dom/untriaged/elements-and-dom-objects/shadowroot-object/shadowroot-attributes/test-012.html
/shadow-dom/untriaged/elements-and-dom-objects/shadowroot-object/shadowroot-methods/test-001.html
/html/semantics/scripting-1/the-template-element/definitions/template-contents-owner-test-002.html
/html/syntax/parsing/template/additions-to-the-in-body-insertion-mode/ignore-html-token.html
/html/syntax/parsing/template/additions-to-the-in-body-insertion-mode/ignore-head-token.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/window-named-properties-003.html
/html/syntax/parsing/template/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-body-context.html
/shadow-dom/untriaged/shadow-trees/reprojection/reprojection-001.html
/shadow-dom/untriaged/shadow-trees/shadow-root-001.html
/shadow-dom/untriaged/html-elements-in-shadow-trees/inert-html-elements/test-001.html
/html/syntax/parsing/template/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-context.html
/shadow-dom/untriaged/elements-and-dom-objects/extensions-to-event-interface/event-path-001.html
/shadow-dom/untriaged/html-elements-in-shadow-trees/html-forms/test-001.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/test-007.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/shadow-root-001.html
/html/syntax/parsing/template/additions-to-the-in-body-insertion-mode/ignore-frameset-token.html
/html/semantics/scripting-1/the-template-element/template-element/template-content-node-document.html
/shadow-dom/untriaged/html-elements-in-shadow-trees/html-forms/test-002.html
/shadow-dom/untriaged/user-interaction/ranges-and-selections/test-001.html
/html/syntax/parsing/template/creating-an-element-for-the-token/template-owner-document.html
/shadow-dom/untriaged/elements-and-dom-objects/shadowroot-object/shadowroot-methods/test-006.html
/html/semantics/scripting-1/the-template-element/definitions/template-contents-owner-test-001.html
/shadow-dom/untriaged/elements-and-dom-objects/shadowroot-object/shadowroot-attributes/test-013.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/window-named-properties-001.html
/html/syntax/parsing/template/additions-to-the-in-body-insertion-mode/ignore-body-token.html
/shadow-dom/untriaged/user-interaction/editing/inheritance-of-content-editable-001.html
/shadow-dom/untriaged/elements-and-dom-objects/shadowroot-object/shadowroot-attributes/test-007.html
/html/semantics/scripting-1/the-template-element/template-element/node-document-changes.html
/html/syntax/parsing/template/additions-to-the-in-frameset-insertion-mode/end-tag-frameset.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/test-009.html
/shadow-dom/untriaged/events/event-dispatch/test-003.html
/html/semantics/scripting-1/the-template-element/template-element/template-descendant-frameset.html
/html/syntax/parsing/template/additions-to-foster-parenting/template-is-not-a-foster-parent-element.html
/shadow-dom/untriaged/elements-and-dom-objects/shadowroot-object/shadowroot-methods/test-007.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/ownerdocument-001.html
/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/origin-check-in-document-open-same-origin-domain.sub.html
/shadow-dom/untriaged/html-elements-in-shadow-trees/html-forms/test-003.html
/shadow-dom/untriaged/elements-and-dom-objects/shadowroot-object/shadowroot-attributes/test-009.html
/html/syntax/parsing/template/additions-to-foster-parenting/template-is-a-foster-parent-element.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/window-named-properties-002.html
/shadow-dom/untriaged/styles/test-008.html
/shadow-dom/untriaged/elements-and-dom-objects/extensions-to-element-interface/attributes/test-006.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/selectors-api-002.html
/shadow-dom/untriaged/elements-and-dom-objects/shadowroot-object/shadowroot-methods/test-004.html
/html/syntax/parsing/template/additions-to-the-in-table-insertion-mode/end-tag-table.html
/html/semantics/scripting-1/the-template-element/innerhtml-on-templates/innerhtml.html
/html/syntax/parsing/template/additions-to-the-in-body-insertion-mode/start-tag-html.html
/shadow-dom/untriaged/shadow-trees/shadow-root-002.html
/shadow-dom/untriaged/user-interaction/ranges-and-selections/test-002.html
/shadow-dom/untriaged/user-interaction/active-element/test-002.html
/html/syntax/parsing/template/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-row-context.html
/html/semantics/scripting-1/the-template-element/additions-to-the-steps-to-clone-a-node/templates-copy-document-owner.html
/html/syntax/parsing/template/additions-to-the-in-body-insertion-mode/generating-of-implied-end-tags.html
/shadow-dom/untriaged/events/retargeting-relatedtarget/test-002.html
/shadow-dom/untriaged/elements-and-dom-objects/shadowroot-object/shadowroot-attributes/activeElement-confirm-return-null.html
/shadow-dom/untriaged/events/retargeting-focus-events/test-002.html
/html/semantics/scripting-1/the-template-element/template-element/template-as-a-descendant.html
/shadow-dom/untriaged/elements-and-dom-objects/shadowroot-object/shadowroot-attributes/test-011.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/selectors-api-001.html
/shadow-dom/untriaged/shadow-trees/nested-shadow-trees/nested_tree_reftest.html
/shadow-dom/untriaged/elements-and-dom-objects/extensions-to-element-interface/methods/test-001.html
/html/semantics/scripting-1/the-template-element/template-element/template-descendant-head.html
/shadow-dom/untriaged/events/event-dispatch/test-002.html
/shadow-dom/untriaged/user-interaction/active-element/test-001.html
/shadow-dom/untriaged/events/retargeting-focus-events/test-001.html
/html/syntax/parsing/template/additions-to-the-in-head-insertion-mode/generating-of-implied-end-tags.html
/html/semantics/scripting-1/the-template-element/template-element/template-descendant-body.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/ownerdocument-002.html
/html/semantics/scripting-1/the-template-element/definitions/template-contents.html
/shadow-dom/untriaged/elements-and-dom-objects/shadowroot-object/shadowroot-methods/test-010.html
/html/semantics/scripting-1/the-template-element/template-element/template-content.html
/html/semantics/scripting-1/the-template-element/definitions/template-contents-owner-document-type.html
/shadow-dom/untriaged/styles/not-apply-in-shadow-root-001.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/dom-tree-accessors-002.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/test-005.html
/html/semantics/scripting-1/the-template-element/serializing-html-templates/outerhtml.html
/shadow-dom/untriaged/styles/test-005.html
/shadow-dom/untriaged/events/retargeting-focus-events/test-003.html
/html/semantics/scripting-1/the-template-element/template-element/content-attribute.html
/shadow-dom/untriaged/events/retargeting-relatedtarget/test-003.html
/shadow-dom/untriaged/events/test-001.html
/html/syntax/parsing/template/additions-to-the-in-body-insertion-mode/start-tag-body.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/test-011.html
/shadow-dom/untriaged/events/event-retargeting/test-001.html
/html/syntax/parsing/template/additions-to-the-in-head-insertion-mode/template-end-tag-without-start-one.html
/shadow-dom/untriaged/elements-and-dom-objects/extensions-to-element-interface/methods/test-002.html
/html/syntax/parsing/template/appending-to-a-template/template-child-nodes.html
/shadow-dom/untriaged/events/retargeting-relatedtarget/test-001.html
/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/origin-check-in-document-open-basic.html
/shadow-dom/untriaged/shadow-trees/upper-boundary-encapsulation/dom-tree-accessors-001.html
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for revert:
Suspect for webkit_tests leak failures (https://crbug.com/692872).
See bug for details.
Original issue's description:
TBR=esprehn@chromium.org,dcheng@chromium.org,avi@chromium.org,erikchen@chromium.org
Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=650433
Review-Url: https://codereview.chromium.org/2696283003
Cr-Commit-Position: refs/heads/master@{#450855}