Add webdriver test for pointer_move action within an iframe#48123
Merged
whimboo merged 1 commit intoweb-platform-tests:masterfrom Sep 16, 2024
Merged
Add webdriver test for pointer_move action within an iframe#48123whimboo merged 1 commit intoweb-platform-tests:masterfrom
whimboo merged 1 commit intoweb-platform-tests:masterfrom
Conversation
Contributor
Author
|
@jgraham or @juliandescottes can you please review? |
juliandescottes
approved these changes
Sep 16, 2024
Contributor
juliandescottes
left a comment
There was a problem hiding this comment.
LGTM, just one nit
0d8a041 to
de8ad8b
Compare
Contributor
Author
|
The Chromium related bug is: GoogleChromeLabs/chromium-bidi#2630 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those added tests demonstrate that for both Chrome and Safari the pointer actions are misbehaving when executed within an iframe. The target coordinates as defined for the action aren't reached because the offset of the iframe isn't taken into account.
CC @sadym-chromium and @gsnedders