Skip to content

Add tests for structured cloning of Temporal objects#46865

Open
Ms2ger wants to merge 2 commits intomasterfrom
temporal-clone
Open

Add tests for structured cloning of Temporal objects#46865
Ms2ger wants to merge 2 commits intomasterfrom
temporal-clone

Conversation

@Ms2ger
Copy link
Copy Markdown
Contributor

@Ms2ger Ms2ger commented Jun 21, 2024

Copy link
Copy Markdown
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add at least one test to ensure the additional steps also run for these objects? E.g., that expandos get copied. Looks reasonable otherwise. (I've decided to trust that the numbers are okay.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants