[Gecko Bug 1897783] Fix incorrect rounding in software rendering of feColorMatrix.#46842
Merged
moz-wptsync-bot merged 1 commit intomasterfrom Dec 13, 2024
Merged
[Gecko Bug 1897783] Fix incorrect rounding in software rendering of feColorMatrix.#46842moz-wptsync-bot merged 1 commit intomasterfrom
moz-wptsync-bot merged 1 commit intomasterfrom
Conversation
wpt-pr-bot
approved these changes
Jun 20, 2024
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
a50c11b to
a398f15
Compare
a398f15 to
9e3a83b
Compare
This doesn't fix a similar problem in ArithmeticCombineTwoPixels because the fixes there have performance implications, appear wrong, or are wrong for common inputs. Since hue-rotate is defined in terms of a color matrix, some tests involving hue-rotate behave slightly differently. Differential Revision: https://phabricator.services.mozilla.com/D211113 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1897783 gecko-commit: 89be5f4935310003f6d40c515547764c387a583c gecko-reviewers: longsonr
9e3a83b to
6cefc09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't fix a similar problem in ArithmeticCombineTwoPixels because the fixes there have performance implications, appear wrong, or are wrong for common inputs.
Since hue-rotate is defined in terms of a color matrix, some tests involving hue-rotate behave slightly differently.
Differential Revision: https://phabricator.services.mozilla.com/D211113
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1897783
gecko-commit: 084a189b3e01b7117595e06c6fd6e897c7fa757c
gecko-reviewers: longsonr