[Gecko Bug 1886441] Part 3 - Implement substitutions in @scope.#46553
Merged
moz-wptsync-bot merged 3 commits intomasterfrom May 30, 2024
Merged
[Gecko Bug 1886441] Part 3 - Implement substitutions in @scope.#46553moz-wptsync-bot merged 3 commits intomasterfrom
@scope.#46553moz-wptsync-bot merged 3 commits intomasterfrom
Conversation
`:scope` gets implicitly added if not present, without contributing specificity (See w3c/csswg-drafts#10196). `&` is replaced with `scope-start` selector, or `:scope` if it not specified. Differential Revision: https://phabricator.services.mozilla.com/D207780 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1886441 gecko-commit: fae17dbd22d2e12315bca8fc854a837fde4dcc7d gecko-reviewers: firefox-style-system-reviewers, emilio
Keep track of implicit scopes for shadow DOM styled separately, as cascade data for shadow DOM are shared. Differential Revision: https://phabricator.services.mozilla.com/D207781 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1886441 gecko-commit: ca2516594d77da2f9c7ea54672bc4199235fb23d gecko-reviewers: firefox-style-system-reviewers, emilio
Differential Revision: https://phabricator.services.mozilla.com/D207783 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1886441 gecko-commit: bddfdb4b7b6686af36f951455e5b6529052cbdf4 gecko-reviewers: firefox-style-system-reviewers, emilio
wpt-pr-bot
approved these changes
May 30, 2024
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:scopegets implicitly added if not present, without contributingspecificity (See w3c/csswg-drafts#10196).
&is replaced withscope-startselector, or:scopeif it notspecified.
Differential Revision: https://phabricator.services.mozilla.com/D207780
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1886441
gecko-commit: fae17dbd22d2e12315bca8fc854a837fde4dcc7d
gecko-reviewers: firefox-style-system-reviewers, emilio