[Gecko Bug 1884424] Support shape() for offset-path and render it.#45389
Merged
moz-wptsync-bot merged 1 commit intomasterfrom Mar 28, 2024
Merged
[Gecko Bug 1884424] Support shape() for offset-path and render it.#45389moz-wptsync-bot merged 1 commit intomasterfrom
moz-wptsync-bot merged 1 commit intomasterfrom
Conversation
We treat it as other basic shapes (excluding path(), which has some special handling and it doesn't rely on the current layout position). Therefore, we don't have any implementation for caching and we would like to leave this part to Bug 1837042. Also, add some more simple tests in css/motion to make sure we render it properly. Differential Revision: https://phabricator.services.mozilla.com/D204440 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1884424 gecko-commit: 232a3ceaa4069c7a3dc9faf06cec8047d7b03131 gecko-reviewers: layout-reviewers, emilio
wpt-pr-bot
approved these changes
Mar 27, 2024
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We treat it as other basic shapes (excluding path(), which has some
special handling and it doesn't rely on the current layout position).
Therefore, we don't have any implementation for caching and we would like to
leave this part to Bug 1837042.
Also, add some more simple tests in css/motion to make sure we render it
properly.
Differential Revision: https://phabricator.services.mozilla.com/D204440
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1884424
gecko-commit: 232a3ceaa4069c7a3dc9faf06cec8047d7b03131
gecko-reviewers: layout-reviewers, emilio