remove assert_* checks on undefined .commandDisabled attribute#4409
Merged
sideshowbarker merged 1 commit intoweb-platform-tests:masterfrom Dec 29, 2016
danbeam:update-dialog-tests
Merged
remove assert_* checks on undefined .commandDisabled attribute#4409sideshowbarker merged 1 commit intoweb-platform-tests:masterfrom danbeam:update-dialog-tests
sideshowbarker merged 1 commit intoweb-platform-tests:masterfrom
danbeam:update-dialog-tests
Conversation
Collaborator
|
Notifying @Ms2ger, @ayg, @gsnedders, @jdm, @jgraham, @sideshowbarker, @zcorpan, and @zqzhang. (Learn how reviewing works.) |
sideshowbarker
approved these changes
Dec 29, 2016
Member
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
Member
|
Fixes #4315 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this seems to vibe with #4331
/cc @deniak
This change is