Conversation
|
Notifying @Ms2ger, @ayg, @gsnedders, @jdm, @jgraham, @sideshowbarker, @zcorpan, and @zqzhang. (Learn how reviewing works.) |
|
Travis is erroring with
But I haven't touched that file and it seems to run the same on w3c-test.org as it does locally with my changes... |
|
@jgraham @sideshowbarker WTF is up with the stability checker on that build? |
|
So it seems like that test was counted as "affected" by these changes (since it has a |
Looks like @domenic tracked it down. Seems like a plus that the affected-tests feature in the stability checker helps catch these kinds of existing problems in other tests (though when this happens I guess we should not expect the current PR submitter to troubleshoot it and fix it but instead should assign it to one of us or to whoever last touched the other test that’s causing the problem). |
|
Yeah it would be better if there were an error message about duplicate test names in Travis though instead of a mysterious "20/10 failures" |
Yes I just now raised #4404 for that |
Follows whatwg/html#2221.
This change is