Skip to content

Test for the removal of keygen#4402

Merged
domenic merged 2 commits intomasterfrom
remove-keygen
Jan 13, 2017
Merged

Test for the removal of keygen#4402
domenic merged 2 commits intomasterfrom
remove-keygen

Conversation

@domenic
Copy link
Member

@domenic domenic commented Dec 28, 2016

Follows whatwg/html#2221.


This change is Reviewable

@wpt-pr-bot
Copy link
Collaborator

@domenic
Copy link
Member Author

domenic commented Dec 28, 2016

Travis is erroring with

ERROR:check_stability:| /html/semantics/scripting-1/the-template-element/template-element/template-as-a-descendant.html | Template element as a descendant of the FRAMESET element. Template element is created by innerHTML | FAIL: 20/10 |

But I haven't touched that file and it seems to run the same on w3c-test.org as it does locally with my changes...

@gsnedders
Copy link
Member

@jgraham @sideshowbarker WTF is up with the stability checker on that build?

@domenic
Copy link
Member Author

domenic commented Dec 28, 2016

So it seems like that test was counted as "affected" by these changes (since it has a <script> referencing a changed resource) and so the stability checker ran on it. It then noticed a pre-existing problem where there were duplicate test names. It didn't give the clearest error message, but fixing the duplicate test names seems to have made the new build pass, so that's good...

@sideshowbarker
Copy link
Member

@jgraham @sideshowbarker WTF is up with the stability checker on that build?

Looks like @domenic tracked it down.

Seems like a plus that the affected-tests feature in the stability checker helps catch these kinds of existing problems in other tests (though when this happens I guess we should not expect the current PR submitter to troubleshoot it and fix it but instead should assign it to one of us or to whoever last touched the other test that’s causing the problem).

@domenic
Copy link
Member Author

domenic commented Dec 29, 2016

Yeah it would be better if there were an error message about duplicate test names in Travis though instead of a mysterious "20/10 failures"

@sideshowbarker
Copy link
Member

Yeah it would be better if there were an error message about duplicate test names in Travis though instead of a mysterious "20/10 failures"

Yes I just now raised #4404 for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants