Update tests for Fullscreen of an iframe's child element#4251
Merged
Conversation
Collaborator
|
Notifying @foolip and @upsuper. (Learn how reviewing works.) |
Member
Author
|
Yeah, you can add me for seeing changes. Tests look good to me. |
Member
Author
|
Thanks @aliams, I'll add it in this PR then. |
Member
Author
|
@jernoble, can I add you to OWNERS as well, or who is most likely to work on Fullscreen in WebKit going forward? |
501bf0a to
f14ed56
Compare
Contributor
|
@foolip Please do add me to OWNERS, thanks. |
Tests for whatwg/fullscreen#45 Also add @aliams and @jernoble to fullscreen/OWNERS.
f14ed56 to
ca113bd
Compare
Member
Author
|
@jernoble, done! Would you also mind reviewing these test changes? The tests will fail in Chrome and Safari. It's a pretty silly corner case, but I intend to fix it in Chrome after implementing Fullscreen in terms of top layer, since the restrictions then don't serve any purpose. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for whatwg/fullscreen#45