[SPC] Add test for SPC authentication in a hidden document#39507
[SPC] Add test for SPC authentication in a hidden document#39507stephenmcgruer merged 1 commit intomasterfrom
Conversation
|
cc @ianbjacobs One note is that Chrome currently throws an |
What does a non-SPC PaymentRequest throw? Should this WPT expect a NotSupportedError then, and we update our implementation to throw that? |
|
Codewise, it also throws an AbortError. Specwise, the two possible places Chrome is choosing to throw an AbortError here (steps 5 or 12.1 of show()) both come before when SPC would have a chance to cause a NotSupportedError to be thrown (during step 17 iirc). So Chrome is perfectly within spec here. This is why we should fix this in Payment Request instead, and maybe we should just do that rather than land the SPC spec PR - thoughts Ian? I think I'll go check if Safari allows Payment Request in a background tab today. If not maybe we can easily spec something in Payment Request quickly. |
Based on my testing, Safari also throws an AbortError if you try to trigger it when the tab is in the background. Reproduction:
|
nickburris
left a comment
There was a problem hiding this comment.
LGTM, thanks for confirming the implementation consistency!
See w3c/secure-payment-confirmation#238