[Gecko Bug 1461589] Add/update CSS parsing tests to cover font-variant-emoji.#36611
Merged
moz-wptsync-bot merged 2 commits intomasterfrom Oct 24, 2022
Merged
[Gecko Bug 1461589] Add/update CSS parsing tests to cover font-variant-emoji.#36611moz-wptsync-bot merged 2 commits intomasterfrom
moz-wptsync-bot merged 2 commits intomasterfrom
Conversation
Differential Revision: https://phabricator.services.mozilla.com/D147496 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1461589 gecko-commit: 98090ae94c2f7f1f36cf9d30b67fbd98d4556bc5 gecko-reviewers: layout-reviewers, emilio
These tests assume the system has both text- and emoji-style glyphs available for U+263A, the old WHITE SMILING FACE symbol that has long existed in legacy fonts, and now also supports an emoji-style rendering. If two distinct presentations are not available, the first (mismatch) test will fail. The spec says: > Even when font-variant-emoji is used, the presence of Variation Selector 15 (U+FE0E) or Variation Selector 16 (U+FE0F) > in the contents of an element override the rendering specified in font-variant-emoji. > Therefore, font-variant-emoji sets a default presentation which the text being rendered can opt out of. So the second test checks that U+263A responds to the property as expected, and that the variation selectors can still override it. Depends on D147496 Differential Revision: https://phabricator.services.mozilla.com/D159495 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1461589 gecko-commit: c1a7287807c1bdbf5d40c4a20ac316f0171d9f32 gecko-reviewers: emilio
wpt-pr-bot
approved these changes
Oct 22, 2022
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: https://phabricator.services.mozilla.com/D147496
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1461589
gecko-commit: 98090ae94c2f7f1f36cf9d30b67fbd98d4556bc5
gecko-reviewers: layout-reviewers, emilio